Chromium Code Reviews| Index: chrome/browser/password_manager/password_manager.cc |
| diff --git a/chrome/browser/password_manager/password_manager.cc b/chrome/browser/password_manager/password_manager.cc |
| index f165660610f0433a4c1db1935928db2e55e76958..f1373e1bf9534e8e288970f26d31c9082c3c6e7c 100644 |
| --- a/chrome/browser/password_manager/password_manager.cc |
| +++ b/chrome/browser/password_manager/password_manager.cc |
| @@ -364,15 +364,21 @@ void PasswordManager::OnPasswordFormsRendered( |
| UMA_HISTOGRAM_COUNTS("PasswordGeneration.Submitted", 1); |
| if (ShouldShowSavePasswordInfoBar()) { |
| - if (CommandLine::ForCurrentProcess()->HasSwitch( |
| + #if defined(USE_AURA) || defined(OS_WIN) |
| + if (CommandLine::ForCurrentProcess()->HasSwitch( |
| switches::kEnableSavePasswordBubble)) { |
| - NotifyPasswordObserver(PasswordObserver::SAVE_NEW_PASSWORD, |
| - provisional_save_manager_->best_matches(), |
| - provisional_save_manager_->pending_credentials()); |
| - } else { |
| + NotifyPasswordObserver( |
| + PasswordObserver::SAVE_NEW_PASSWORD, |
| + provisional_save_manager_->best_matches(), |
| + provisional_save_manager_->pending_credentials()); |
| + } { |
|
markusheintz_
2013/12/19 09:25:51
here is an "else" missing.
npentrel
2013/12/19 22:48:10
Done.
|
| + delegate_->AddSavePasswordInfoBarIfPermitted( |
| + provisional_save_manager_.release()); |
| + } |
| + #else |
| delegate_->AddSavePasswordInfoBarIfPermitted( |
| provisional_save_manager_.release()); |
| - } |
| + #endif |
| } else { |
| provisional_save_manager_->Save(); |
| provisional_save_manager_.reset(); |
| @@ -450,11 +456,13 @@ void PasswordManager::Autofill( |
| break; |
| } |
| - if (CommandLine::ForCurrentProcess()->HasSwitch( |
| - switches::kEnableSavePasswordBubble)) { |
| - NotifyPasswordObserver(PasswordObserver::AUTOFILL_PASSWORDS, best_matches, |
| - form_for_autofill); |
| - } |
| + #if defined(USE_AURA) || defined(OS_WIN) |
| + if (CommandLine::ForCurrentProcess()->HasSwitch( |
| + switches::kEnableSavePasswordBubble)) { |
| + NotifyPasswordObserver(PasswordObserver::AUTOFILL_PASSWORDS, best_matches, |
| + form_for_autofill); |
| + } |
| + #endif |
| } |
| void PasswordManager::UpdateBestMatches( |