Only allow enabling of ManagePasswordsBubble if USE_AURA or WIN_OS is defined

Only allow enabling of ManagePasswordsBubble if USE_AURA or WIN_OS is defined.

BUG=261628
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242100

[markusheintz_, 2013-12-18 09:32:53]

https://codereview.chromium.org/98643008/diff/1/chrome/browser/password_manag...
File chrome/browser/password_manager/password_manager.cc (right):

https://codereview.chromium.org/98643008/diff/1/chrome/browser/password_manag...
chrome/browser/password_manager/password_manager.cc:368: #if defined(USE_AURA)
I guess this could be USE_AURA or OS_WIN.

https://codereview.chromium.org/98643008/diff/1/chrome/browser/password_manag...
chrome/browser/password_manager/password_manager.cc:460: #if defined(USE_AURA)
Same as above

[npentrel, 2013-12-18 13:28:47]

https://codereview.chromium.org/98643008/diff/1/chrome/browser/password_manag...
File chrome/browser/password_manager/password_manager.cc (right):

https://codereview.chromium.org/98643008/diff/1/chrome/browser/password_manag...
chrome/browser/password_manager/password_manager.cc:368: #if defined(USE_AURA)
On 2013/12/18 09:32:54, markusheintz_ wrote:
> I guess this could be USE_AURA or OS_WIN.

Done.

https://codereview.chromium.org/98643008/diff/1/chrome/browser/password_manag...
chrome/browser/password_manager/password_manager.cc:460: #if defined(USE_AURA)
On 2013/12/18 09:32:54, markusheintz_ wrote:
> Same as above

Done.

[markusheintz_, 2013-12-18 14:49:15]

https://codereview.chromium.org/98643008/diff/20001/chrome/browser/password_m...
File chrome/browser/password_manager/password_manager.cc (right):

https://codereview.chromium.org/98643008/diff/20001/chrome/browser/password_m...
chrome/browser/password_manager/password_manager.cc:374: } else {
Wrong indentation. Please move two spaces to the left.

https://codereview.chromium.org/98643008/diff/20001/chrome/browser/password_m...
chrome/browser/password_manager/password_manager.cc:376:
provisional_save_manager_.release());
I guess this block should also be non WIN and non Aura builds. Right?

[npentrel, 2013-12-18 15:01:10]

https://codereview.chromium.org/98643008/diff/20001/chrome/browser/password_m...
File chrome/browser/password_manager/password_manager.cc (right):

https://codereview.chromium.org/98643008/diff/20001/chrome/browser/password_m...
chrome/browser/password_manager/password_manager.cc:374: } else {
On 2013/12/18 14:49:15, markusheintz_ wrote:
> Wrong indentation. Please move two spaces to the left.

Done.

https://codereview.chromium.org/98643008/diff/20001/chrome/browser/password_m...
chrome/browser/password_manager/password_manager.cc:376:
provisional_save_manager_.release());
On 2013/12/18 14:49:15, markusheintz_ wrote:
> I guess this block should also be non WIN and non Aura builds. Right?

Done.

[markusheintz_, 2013-12-19 09:25:51]

LGTM after fixing my comment.

https://codereview.chromium.org/98643008/diff/40001/chrome/browser/password_m...
File chrome/browser/password_manager/password_manager.cc (right):

https://codereview.chromium.org/98643008/diff/40001/chrome/browser/password_m...
chrome/browser/password_manager/password_manager.cc:374: } {
here is an "else" missing.

[npentrel, 2013-12-19 22:48:10]

https://codereview.chromium.org/98643008/diff/40001/chrome/browser/password_m...
File chrome/browser/password_manager/password_manager.cc (right):

https://codereview.chromium.org/98643008/diff/40001/chrome/browser/password_m...
chrome/browser/password_manager/password_manager.cc:374: } {
On 2013/12/19 09:25:51, markusheintz_ wrote:
> here is an "else" missing.

Done.

[npentrel, 2013-12-19 22:54:12]

Hi Garrett,

PLease have a look at this small CL. It only adds another condition so that the
ManagePasswordsBubble can only be used with the flag on AURA/WIN.

Thanks,
Naomi

[Garrett Casto, 2013-12-19 22:58:06]

lgtm

[commit-bot: I haz the power, 2013-12-20 10:12:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/npentrel@chromium.org/98643008/100001

[commit-bot: I haz the power, 2013-12-20 14:35:14]

Change committed as 242100