render_pictures: add --writeJsonSummaryPath

render_pictures: add --writeJsonSummaryPath

Known issues:
- JSON summary will be empty if --writePath not specified also
- testNames within summary do not include the config (8888, gpu, etc.)

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=12680

[epoger, 2013-12-13 18:33:25]

Ravi- as noted in the description, there are a couple of shortcomings still, but
I think it will already perform as you need.

Ready for review at patchset 2.

https://codereview.chromium.org/98643007/diff/20001/gyp/tools.gyp
File gyp/tools.gyp (right):

https://codereview.chromium.org/98643007/diff/20001/gyp/tools.gyp#newcode144
gyp/tools.gyp:144: 'flags.gyp:flags',
alphabetized dependencies throughout this file

https://codereview.chromium.org/98643007/diff/20001/gyp/tools.gyp#newcode221
gyp/tools.gyp:221: 'jsoncpp.gyp:jsoncpp',
hiding amongst the re-alphabetizations are these added dependencies on jsoncpp

https://codereview.chromium.org/98643007/diff/20001/tools/PictureRenderer.cpp
File tools/PictureRenderer.cpp (right):

https://codereview.chromium.org/98643007/diff/20001/tools/PictureRenderer.cpp...
tools/PictureRenderer.cpp:569: * Copies the entirety of the src bitmap
(typically a tile) into a portion of the dst bitmap.
Added this documentation because I thought the function's name was misleading.

Let me know if you'd like me to change the function's name... I was thinking
maybe
bitmapCopyAtOffset(src, dst, xOffset, yOffset)

https://codereview.chromium.org/98643007/diff/20001/tools/render_pictures_mai...
File tools/render_pictures_main.cpp (right):

https://codereview.chromium.org/98643007/diff/20001/tools/render_pictures_mai...
tools/render_pictures_main.cpp:35: DEFINE_string(writeJsonSummaryPath, "", "File
to write a JSON summary of image results to. "
Tested by downloading some SKPs into $SKPDIR, and then...

make -j 30 \
 && OUTDIR=out/render_pictures/after \
 && rm -rf $OUTDIR \
 && mkdir -p $OUTDIR \
 && out/Debug/render_pictures -r $SKPDIR/desk_weather.skp --bbh grid 256 256
--clone 1 --config 8888 --mode tile 256 256 --validate --writePath $OUTDIR
--writeJsonSummaryPath $OUTDIR/desk_weather_tiles.json \
 && out/Debug/render_pictures -r $SKPDIR/desk_wordpress.skp --bbh grid 256 256
--clone 1 --config 8888 --mode tile 256 256 --validate --writePath $OUTDIR
--writeWholeImage --writeJsonSummaryPath $OUTDIR/desk_wordpress_wholeimage.json
\
 && out/Debug/render_pictures -r $SKPDIR/tabl_sahadan.skp --bbh grid 256 256
--clone 1 --config 8888 --mode tile 256 256 --validate --writeJsonSummaryPath
$OUTDIR/tabl_sahadan_tiles.json \
 && out/Debug/render_pictures -r $SKPDIR/tabl_slashdot.skp --bbh grid 256 256
--clone 1 --config 8888 --mode tile 256 256 --validate --writeWholeImage
--writeJsonSummaryPath $OUTDIR/tabl_slashdot_wholeimage.json \
 && diff --recursive out/render_pictures/before out/render_pictures/after


$ cat out/render_pictures/after/desk_weather_tiles.json
{
   "actual-results" : {
      "no-comparison" : {
         "desk_weather0.png" : [ "bitmap-64bitMD5", 2761594137545201178 ],
         "desk_weather1.png" : [ "bitmap-64bitMD5", 10335887226153132199 ],
         "desk_weather10.png" : [ "bitmap-64bitMD5", 11831915483066711082 ],
         "desk_weather11.png" : [ "bitmap-64bitMD5", 3961274080845200539 ],
...
         "desk_weather8.png" : [ "bitmap-64bitMD5", 2013231079123882101 ],
         "desk_weather9.png" : [ "bitmap-64bitMD5", 12507987515479037608 ]
      }
   }
}

[rmistry, 2013-12-13 19:04:11]

Yes this should work perfectly for what I wanted.
Thanks for doing this!

LGTM

https://codereview.chromium.org/98643007/diff/20001/tools/PictureRenderer.cpp
File tools/PictureRenderer.cpp (right):

https://codereview.chromium.org/98643007/diff/20001/tools/PictureRenderer.cpp...
tools/PictureRenderer.cpp:569: * Copies the entirety of the src bitmap
(typically a tile) into a portion of the dst bitmap.
On 2013/12/13 18:33:25, epoger wrote:
> Added this documentation because I thought the function's name was misleading.
> 
> Let me know if you'd like me to change the function's name... I was thinking
> maybe
> bitmapCopyAtOffset(src, dst, xOffset, yOffset)

looks fine to me

[commit-bot: I haz the power, 2013-12-13 19:12:01]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/epoger@google.com/98643007/40001

[commit-bot: I haz the power, 2013-12-13 20:12:12]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/epoger@google.com/98643007/60001

[commit-bot: I haz the power, 2013-12-13 20:52:46]

Change committed as 12680