Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 98643007: render_pictures: add --writeJsonSummaryPath (Closed)

Created:
7 years ago by epoger
Modified:
7 years ago
Reviewers:
rmistry
CC:
skia-review_googlegroups.com, borenet, benchen
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

render_pictures: add --writeJsonSummaryPath Known issues: - JSON summary will be empty if --writePath not specified also - testNames within summary do not include the config (8888, gpu, etc.) BUG= Committed: http://code.google.com/p/skia/source/detail?r=12680

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 5

Patch Set 3 : rename one function #

Patch Set 4 : fix dependencies (nice catch, trybots) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -53 lines) Patch
M gyp/tools.gyp View 1 2 3 10 chunks +26 lines, -18 lines 0 comments Download
M tools/PictureRenderer.h View 5 chunks +31 lines, -0 lines 0 comments Download
M tools/PictureRenderer.cpp View 1 2 14 chunks +97 lines, -23 lines 0 comments Download
M tools/render_pictures_main.cpp View 9 chunks +53 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
Ravi- as noted in the description, there are a couple of shortcomings still, but I ...
7 years ago (2013-12-13 18:33:25 UTC) #1
rmistry
Yes this should work perfectly for what I wanted. Thanks for doing this! LGTM https://codereview.chromium.org/98643007/diff/20001/tools/PictureRenderer.cpp ...
7 years ago (2013-12-13 19:04:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/98643007/40001
7 years ago (2013-12-13 19:12:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/98643007/60001
7 years ago (2013-12-13 20:12:12 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-13 20:52:46 UTC) #5
Message was sent while issue was closed.
Change committed as 12680

Powered by Google App Engine
This is Rietveld 408576698