chrome/browser/ui/translate/translate_bubble_model.h - Issue 98643003: Translate new UX: Fix the visual and behavior of 'Done' button

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/translate/translate_bubble_model.h

Issue 98643003: Translate new UX: Fix the visual and behavior of 'Done' button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/translate/translate_bubble_model_impl.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_TRANSLATE_TRANSLATE_BUBBLE_MODEL_H_	5 #ifndef CHROME_BROWSER_UI_TRANSLATE_TRANSLATE_BUBBLE_MODEL_H_

6 #define CHROME_BROWSER_UI_TRANSLATE_TRANSLATE_BUBBLE_MODEL_H_	6 #define CHROME_BROWSER_UI_TRANSLATE_TRANSLATE_BUBBLE_MODEL_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 #include "base/strings/string16.h"	10 #include "base/strings/string16.h"

(...skipping 66 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
77 virtual void SetAlwaysTranslate(bool value) = 0;	77 virtual void SetAlwaysTranslate(bool value) = 0;

78	78

79 // Starts translating the current page.	79 // Starts translating the current page.

80 virtual void Translate() = 0;	80 virtual void Translate() = 0;

81	81

82 // Reverts translation.	82 // Reverts translation.

83 virtual void RevertTranslation() = 0;	83 virtual void RevertTranslation() = 0;

84	84

85 // Processes when the user declines translation.	85 // Processes when the user declines translation.

86 virtual void TranslationDeclined() = 0;	86 virtual void TranslationDeclined() = 0;

	87

	88 // Returns true if the page is translated in the current language pair.

	89 virtual bool IsPageTranslatedInCurrentPair() const = 0;
	sky 2013/12/02 21:43:58 'pair'? No where do you talk about what 'pair' mea 'pair'? No where do you talk about what 'pair' means in this context. hajimehoshi 2013/12/03 03:26:06 Sure, I avoided to use the word 'pair'. Show quoted text On 2013/12/02 21:43:58, sky wrote: > 'pair'? No where do you talk about what 'pair' means in this context. Sure, I avoided to use the word 'pair'.
87 };	90 };

88	91

89 #endif // CHROME_BROWSER_UI_TRANSLATE_TRANSLATE_BUBBLE_MODEL_H_	92 #endif // CHROME_BROWSER_UI_TRANSLATE_TRANSLATE_BUBBLE_MODEL_H_

OLD	NEW