Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 986413003: Use it=erase instead of old_it=it. (Closed)

Created:
5 years, 9 months ago by Bence
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use it=erase instead of old_it=it. BUG=392576 Committed: https://crrev.com/9d2bd87cf57c75cc752a25e28c90773994e0bdbd Cr-Commit-Position: refs/heads/master@{#319763}

Patch Set 1 #

Patch Set 2 : Nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M net/http/http_server_properties_impl.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan, PTAL. Thanks.
5 years, 9 months ago (2015-03-09 21:07:27 UTC) #2
Ryan Hamilton
lgtm
5 years, 9 months ago (2015-03-09 22:52:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986413003/20001
5 years, 9 months ago (2015-03-09 23:05:13 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-09 23:23:38 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 23:24:27 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9d2bd87cf57c75cc752a25e28c90773994e0bdbd
Cr-Commit-Position: refs/heads/master@{#319763}

Powered by Google App Engine
This is Rietveld 408576698