Fix Ozone ECS bot

Fix Ozone ECS bot

Remove components.gpy:session_manager_component from global dependency
list since it is already included if chromeos==1 or use_ash==1.

BUG=none
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg;tryserver.chromium.linux:linux_ecs_ozone
TBR=brettw@chromium.org

Committed: https://crrev.com/8c6aa8edcb4af22c634df10faffb41ae004cba0e
Cr-Commit-Position: refs/heads/master@{#320181}

[dnicoara, 2015-03-10 17:42:51]

dnicoara@chromium.org changed reviewers:
+ brettw@chromium.org, dpranke@chromium.org

[dnicoara, 2015-03-10 17:42:52]

PTAL

[Dirk Pranke, 2015-03-10 20:38:29]

Can you remove the equivalent entry from src/BUILD.gn (line 243, I think) and
make sure the core component is not defined if !is_chromeos && !use_ash ?

We need to make sure the two files keep the same lists and have the same logic.

[Dirk Pranke, 2015-03-10 20:39:47]

On 2015/03/10 20:38:29, Dirk Pranke wrote:
> Can you remove the equivalent entry from src/BUILD.gn (line 243, I think) and
> make sure the core component is not defined if !is_chromeos && !use_ash ?
> 
> We need to make sure the two files keep the same lists and have the same
logic.

Alternatively, make sure that we never depend on //components/session/core in
those circumstances, so that the file isn't opened.

You could add an assert() call to the components/session_manager/core/BUILD.gn
file to ensure this.

[dnicoara, 2015-03-10 21:25:16]

On 2015/03/10 20:38:29, Dirk Pranke wrote:
> Can you remove the equivalent entry from src/BUILD.gn (line 243, I think) and
> make sure the core component is not defined if !is_chromeos && !use_ash ?
> 
> We need to make sure the two files keep the same lists and have the same
logic.

Done.

I tried adding the assert, though some of the linux GN bots complained about
use_ash being an unidentified identifier.

[Dirk Pranke, 2015-03-10 21:31:06]

On 2015/03/10 21:25:16, dnicoara wrote:
> On 2015/03/10 20:38:29, Dirk Pranke wrote:
> > Can you remove the equivalent entry from src/BUILD.gn (line 243, I think)
and
> > make sure the core component is not defined if !is_chromeos && !use_ash ?
> > 
> > We need to make sure the two files keep the same lists and have the same
> logic.
> 
> Done.

lgtm.

> I tried adding the assert, though some of the linux GN bots complained about
> use_ash being an unidentified identifier.

You probably needed to add import("//build/config/ui.gni") at the top of the
file.

[dnicoara, 2015-03-11 18:52:10]

The CQ bit was checked by dnicoara@chromium.org

[commit-bot: I haz the power, 2015-03-11 19:38:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/986383003/40001

[commit-bot: I haz the power, 2015-03-11 23:20:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-11 23:21:51]

Patchset 3 (id:??) landed as
https://crrev.com/8c6aa8edcb4af22c634df10faffb41ae004cba0e
Cr-Commit-Position: refs/heads/master@{#320181}