Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1767)

Unified Diff: base/base_paths_win.h

Issue 986373006: Add DIR_PROGRAM_FILES6432 to PathService to return "Program Files" on both 64-bit and 32-bit platfo… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/base_paths_win.cc » ('j') | base/base_paths_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base_paths_win.h
diff --git a/base/base_paths_win.h b/base/base_paths_win.h
index 032de348c5c82a7f5dcd75fcc499c88b232b0021..4ab6af1672061723e0be83f7c367cfb21092642a 100644
--- a/base/base_paths_win.h
+++ b/base/base_paths_win.h
@@ -16,8 +16,14 @@ enum {
DIR_WINDOWS, // Windows directory, usually "c:\windows"
DIR_SYSTEM, // Usually c:\windows\system32"
- DIR_PROGRAM_FILES, // Usually c:\program files
- DIR_PROGRAM_FILESX86, // Usually c:\program files or c:\program files (x86)
+ // 32-bit 32-bit on 64-bit 64-bit on 64-bit
+ // DIR_PROGRAM_FILES 1 2 1
grt (UTC plus 2) 2015/03/12 13:34:44 (these are my comments for my own sanity) == FOLDE
+ // DIR_PROGRAM_FILESX86 1 2 2
grt (UTC plus 2) 2015/03/12 13:34:44 == FOLDERID_ProgramFilesX86
+ // DIR_PROGRAM_FILES6432 1 1 1
grt (UTC plus 2) 2015/03/12 13:34:44 #if defined(_WIN64) FOLDERID_ProgramFilesX64 #else
+ // 1 - C:\Program Files 2 - C:\Program Files (x86)
+ DIR_PROGRAM_FILES, // See table above.
+ DIR_PROGRAM_FILESX86, // See table above.
+ DIR_PROGRAM_FILES6432, // See table above.
DIR_IE_INTERNET_CACHE, // Temporary Internet Files directory.
DIR_COMMON_START_MENU, // Usually "C:\Documents and Settings\All Users\
« no previous file with comments | « no previous file | base/base_paths_win.cc » ('j') | base/base_paths_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698