Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 986343002: Adjust distance field glyph and font atlas sizes to maximize storage. (Closed)

Created:
5 years, 9 months ago by jvanverth1
Modified:
5 years, 9 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Adjust distance field glyph and font atlas sizes to maximize storage. Because of high DPI devices, we need more room in the glyph atlas for the larger glyphs. These settings will allow 4 of the distance field glyphs to fit in one Plot (increasing the storage from 32 large glyphs to 128), and still permit us to handle glyphs up to a 312 point size. BUG=chromium:458791 Committed: https://skia.googlesource.com/skia/+/d2737ad7dd8f4ea94a74034027014fd3d78923cb Committed: https://skia.googlesource.com/skia/+/07e245ffe1ca7f781590fcff904c2922c2269781 Committed: https://skia.googlesource.com/skia/+/be03bb6cef8c698a20aa5c9dbac827686aabc623

Patch Set 1 #

Patch Set 2 : Make the plot size dependent on max sdf size #

Patch Set 3 : Fix comparison in compile assert #

Patch Set 4 : Remove DEBUG_TEXT_SIZE #

Patch Set 5 : Add checks for atlas size #

Patch Set 6 : Update font atlas sizes to fit on Xoom and Nexus 7 #

Patch Set 7 : Rebase to ToT #

Patch Set 8 : Restore the rest of the patch #

Patch Set 9 : Use texture clamping with NPOT text atlas #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -14 lines) Patch
M src/gpu/GrBitmapTextContext.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 2 3 4 5 6 7 8 3 chunks +6 lines, -4 lines 0 comments Download
M src/gpu/GrFontAtlasSizes.h View 1 2 3 4 5 6 7 1 chunk +16 lines, -9 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
jvanverth1
5 years, 9 months ago (2015-03-09 15:05:33 UTC) #3
jvanverth1
Btw, once this change is in, I can turn on distance field text on Android. ...
5 years, 9 months ago (2015-03-09 15:14:13 UTC) #4
joshualitt
On 2015/03/09 15:14:13, jvanverth1 wrote: > Btw, once this change is in, I can turn ...
5 years, 9 months ago (2015-03-09 15:53:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986343002/80001
5 years, 9 months ago (2015-03-09 16:21:22 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/d2737ad7dd8f4ea94a74034027014fd3d78923cb
5 years, 9 months ago (2015-03-09 16:45:43 UTC) #9
jvanverth1
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/986333005/ by jvanverth@google.com. ...
5 years, 9 months ago (2015-03-09 19:15:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986343002/140001
5 years, 9 months ago (2015-03-10 13:47:43 UTC) #13
commit-bot: I haz the power
Committed patchset #8 (id:140001) as https://skia.googlesource.com/skia/+/07e245ffe1ca7f781590fcff904c2922c2269781
5 years, 9 months ago (2015-03-10 13:53:31 UTC) #14
jvanverth1
A revert of this CL (patchset #8 id:140001) has been created in https://codereview.chromium.org/995863002/ by jvanverth@google.com. ...
5 years, 9 months ago (2015-03-10 15:22:08 UTC) #15
jvanverth1
On 2015/03/10 15:22:08, jvanverth1 wrote: > A revert of this CL (patchset #8 id:140001) has ...
5 years, 9 months ago (2015-03-10 18:14:56 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986343002/160001
5 years, 9 months ago (2015-03-10 18:47:14 UTC) #19
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 18:53:42 UTC) #20
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/be03bb6cef8c698a20aa5c9dbac827686aabc623

Powered by Google App Engine
This is Rietveld 408576698