chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h - Issue 986333006: Center permission bubble if location bar is hidden in MacOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h

Issue 986333006: Center permission bubble if location bar is hidden in MacOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fallthrough Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/base_bubble_controller.mm ('k') | chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm » ('j') | chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h

index de6816fcb6d9cca53ab606c0c97e70b30ca9b2be..87c6374bdd215c41402f3f3ed33af4f52bac9dbb 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h

+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h

@@ -8,6 +8,7 @@

#include "base/mac/scoped_nsobject.h"

#include "base/macros.h"

#include "base/memory/weak_ptr.h"

+#include "chrome/browser/ui/cocoa/info_bubble_view.h"

#include "chrome/browser/ui/website_settings/permission_bubble_view.h"

#include "content/public/browser/web_contents.h"

@@ -43,6 +44,9 @@ class PermissionBubbleCocoa : public PermissionBubbleView {

// Change the parent window to be used the next time the bubble is shown.

void SwitchParentWindow(NSWindow* parent);

+ bool HasOmnibar();

groby-ooo-7-16 2015/03/16 22:09:35 Why is this public?

hcarmona 2015/03/30 20:44:28 Doesn't need to be public. Made protected. Or woul

+ info_bubble::BubbleArrowLocation GetArrowLocation();

private:

NSWindow* parent_window_; // Weak.

Delegate* delegate_; // Weak.