Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7962)

Unified Diff: chrome/browser/ui/cocoa/base_bubble_controller.mm

Issue 986333006: Center permission bubble if location bar is hidden in MacOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix more tests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/base_bubble_controller.mm
diff --git a/chrome/browser/ui/cocoa/base_bubble_controller.mm b/chrome/browser/ui/cocoa/base_bubble_controller.mm
index c8ca24ceb8e9ee0ab1f03a2514bad677968b67f4..0b795c491aac8afa34b4047af010904fc8ce6f8f 100644
--- a/chrome/browser/ui/cocoa/base_bubble_controller.mm
+++ b/chrome/browser/ui/cocoa/base_bubble_controller.mm
@@ -341,10 +341,8 @@
origin.x -= offsets.width;
break;
case info_bubble::kTopCenter:
- origin.x -= NSWidth([window frame]) / 2.0;
- break;
case info_bubble::kNoArrow:
groby-ooo-7-16 2015/03/10 23:34:13 If we _must_ fall through, mark this as // FALLTHR
hcarmona 2015/03/11 22:38:03 Updated with // FALLTHROUGH. Looked into the zoom
- NOTREACHED();
+ origin.x -= NSWidth([window frame]) / 2.0;
break;
}
break;
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698