chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm - Issue 986333006: Center permission bubble if location bar is hidden in MacOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

Issue 986333006: Center permission bubble if location bar is hidden in MacOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test names Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm ('k') | chrome/browser/ui/website_settings/permission_bubble_browser_test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

index 5e74eff1e3115ca8e6e6a56bc28e5a887995c709..1dd508e0844a6eee06b48c2483583b3b770ebc2f 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

@@ -234,7 +234,7 @@ class MenuDelegate : public ui::SimpleMenuModel::Delegate {

anchoredAt:NSZeroPoint])) {

[self setShouldCloseOnResignKey:NO];

[self setShouldOpenAsKeyWindow:YES];

- [[self bubble] setArrowLocation:info_bubble::kTopLeft];

+ [[self bubble] setArrowLocation:bridge->GetArrowLocation()];

bridge_ = bridge;

NSNotificationCenter* center = [NSNotificationCenter defaultCenter];

[center addObserver:self