chrome/browser/ui/cocoa/base_bubble_controller.mm - Issue 986333006: Center permission bubble if location bar is hidden in MacOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/base_bubble_controller.mm

Issue 986333006: Center permission bubble if location bar is hidden in MacOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix broken tests Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h » ('j') | chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/base_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/base_bubble_controller.mm b/chrome/browser/ui/cocoa/base_bubble_controller.mm

index c8ca24ceb8e9ee0ab1f03a2514bad677968b67f4..d6399a12471851393945ec2d41510cf7653d4660 100644

--- a/chrome/browser/ui/cocoa/base_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/base_bubble_controller.mm

@@ -340,12 +340,11 @@

case info_bubble::kTopLeft:

origin.x -= offsets.width;

break;

+ case info_bubble::kNoArrow:

+ // FALLTHROUGH

groby-ooo-7-16 2015/04/08 18:39:15 Please always close comments with a period - see s

hcarmona 2015/04/10 18:54:07 Done.

case info_bubble::kTopCenter:

origin.x -= NSWidth([window frame]) / 2.0;

break;

- case info_bubble::kNoArrow:

- NOTREACHED();

- break;

}

break;

}