chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm - Issue 986333006: Center permission bubble if location bar is hidden in MacOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

Issue 986333006: Center permission bubble if location bar is hidden in MacOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Apply Feedback Part 1 Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browsertest.mm ('K') | « chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browsertest.mm ('k') | chrome/browser/ui/startup/startup_browser_creator_impl.h » ('j') | chrome/browser/ui/startup/startup_browser_creator_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

index 831217f9192f248006ed92f02145fac55e733df4..b25d8cc472650d8b7c1316f6d57846d99c98529d 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

@@ -230,7 +230,7 @@ class MenuDelegate : public ui::SimpleMenuModel::Delegate {

anchoredAt:NSZeroPoint])) {

[self setShouldCloseOnResignKey:NO];

[self setShouldOpenAsKeyWindow:NO];

- [[self bubble] setArrowLocation:info_bubble::kTopLeft];

+ [[self bubble] setArrowLocation:bridge->GetArrowLocation()];

bridge_ = bridge;

NSNotificationCenter* center = [NSNotificationCenter defaultCenter];

[center addObserver:self