chrome/browser/ui/startup/startup_browser_creator_impl.h - Issue 986333006: Center permission bubble if location bar is hidden in MacOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_impl.h

Issue 986333006: Center permission bubble if location bar is hidden in MacOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Attempt to fix failures in new tests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browsertest.mm ('K') | « chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/startup_browser_creator_impl.h

diff --git a/chrome/browser/ui/startup/startup_browser_creator_impl.h b/chrome/browser/ui/startup/startup_browser_creator_impl.h

index 8103e208e2145bb205fba476f4540029cfd4c912..173a87736dd1ea9db873727aebfcf6662c775171 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_impl.h

+++ b/chrome/browser/ui/startup/startup_browser_creator_impl.h

@@ -78,6 +78,7 @@ class StartupBrowserCreatorImpl {

private:

FRIEND_TEST_ALL_PREFIXES(BrowserTest, RestorePinnedTabs);

FRIEND_TEST_ALL_PREFIXES(BrowserTest, AppIdSwitch);

+ FRIEND_TEST_ALL_PREFIXES(PermissionBubbleCocoaAppTest, AppHasNoLocationBar);

// If the process was launched with the web application command line flags,

// e.g. --app=http://www.google.com/ or --app_id=... return true.