Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h

Issue 986333006: Center permission bubble if location bar is hidden in MacOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Attempt to fix failures in new tests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h
diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h
index de6816fcb6d9cca53ab606c0c97e70b30ca9b2be..140af2062a880dd7beb8864a1986c521b948315d 100644
--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h
+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h
@@ -8,6 +8,7 @@
#include "base/mac/scoped_nsobject.h"
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
+#include "chrome/browser/ui/cocoa/info_bubble_view.h"
#include "chrome/browser/ui/website_settings/permission_bubble_view.h"
#include "content/public/browser/web_contents.h"
@@ -43,7 +44,13 @@ class PermissionBubbleCocoa : public PermissionBubbleView {
// Change the parent window to be used the next time the bubble is shown.
void SwitchParentWindow(NSWindow* parent);
-private:
+ info_bubble::BubbleArrowLocation GetArrowLocation();
+
+ protected:
+ // Should only be called in this class. Protected/virtual for ease of testing.
+ virtual bool HasLocationBar();
+
+ private:
NSWindow* parent_window_; // Weak.
Delegate* delegate_; // Weak.

Powered by Google App Engine
This is Rietveld 408576698