Center permission bubble if location bar is hidden in MacOS.

chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h"
 
 #import "chrome/browser/ui/cocoa/base_bubble_controller.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
 #import "chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h"
@@ skipping 45 matching lines @@
   // TODO(gbillock): implement. Should return true if the mouse is not over the
   // dialog.
   return false;
 }
 
 void PermissionBubbleCocoa::OnBubbleClosing() {
   bubbleController_ = nil;
 }
 
 NSPoint PermissionBubbleCocoa::GetAnchorPoint() {
-  LocationBarViewMac* location_bar =
-      [[parent_window_ windowController] locationBarBridge];
-  DCHECK(location_bar);
-  NSPoint anchor = location_bar->GetPageInfoBubblePoint();
+  NSPoint anchor;
+  if (HasLocationBar()) {
+    LocationBarViewMac* location_bar =
+        [[parent_window_ windowController] locationBarBridge];
+    anchor = location_bar->GetPageInfoBubblePoint();
+  } else {
+    // Center the bubble if there's no location bar.
+    NSView* content_view = parent_window_.contentView;

[groby-ooo-7-16, 2015/04/10 20:58:55]

[parent_window_ contentView];

[hcarmona, 2015/04/13 21:13:24]

Done.

+    anchor.y = content_view.frame.size.height;

[groby-ooo-7-16, 2015/04/10 20:58:55]

NSMaxY([content_view frame]); (This is not height, since frame can start at
offset>0)

[hcarmona, 2015/04/13 21:13:24]

Done.

+    anchor.x = (content_view.frame.size.width) / 2;

[groby-ooo-7-16, 2015/04/10 20:58:55]

NSMidX([content_view frame]);

[hcarmona, 2015/04/13 21:13:24]

Done.

+  }
+
   return [parent_window_ convertBaseToScreen:anchor];
 }
 
 NSWindow* PermissionBubbleCocoa::window() {
   return [bubbleController_ window];
 }
 
 void PermissionBubbleCocoa::SwitchParentWindow(NSWindow* parent) {
   parent_window_ = parent;
 }
+
+bool PermissionBubbleCocoa::HasLocationBar() {
+  LocationBarViewMac* location_bar_bridge =
+      [[parent_window_ windowController] locationBarBridge];
+  if (location_bar_bridge) {
+    // It is necessary to check that the location bar bridge will actually
+    // support the location bar. This is important because an application window
+    // will have a location_bar_bridge but not have a location bar.
+    return location_bar_bridge->browser()->SupportsWindowFeature(

[groby-ooo-7-16, 2015/04/08 18:39:15]

I'm wondering if we shouldn't simply pass the browser to PermissionBubbleCocoa
when we create it. That avoids a lot of dancing around here - it just becomes a
call to SupportsWindowFeature.

[hcarmona, 2015/04/10 18:54:07]

|parent_window_| can be updated. When that happens we may have a different
browser.

[groby-ooo-7-16, 2015/04/10 20:58:55]

In what case would that happen?  

[hcarmona, 2015/04/13 21:13:24]

This can happen when a site requests to transition to fullscreen. A new window
is created and the permission bubble should now be part of that window.
Currently broken: crbug.com/165980

+        Browser::FEATURE_LOCATIONBAR);
+  }
+  return false;
+}
+
+info_bubble::BubbleArrowLocation PermissionBubbleCocoa::GetArrowLocation() {

[groby-ooo-7-16, 2015/04/08 18:39:15]

Is there any way we can hoist this policy out into platform independent code?
After all, we don't want an arrow on Views either in the fullscreen case, do we?

[hcarmona, 2015/04/10 18:54:07]

In cocoa we use info_bubble::BubbleArrowLocation
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

In views we use views::BubbleBorder::Arrow
https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/bubble/bu...

We can refactor this in a separate CL.

[groby-ooo-7-16, 2015/04/10 20:58:55]

Please file a bug for that so we don't forget :)

[hcarmona, 2015/04/13 21:13:24]

Done. crbug.com/476662

+  return HasLocationBar() ? info_bubble::kTopLeft : info_bubble::kNoArrow;

[groby-ooo-7-16, 2015/04/10 20:58:55]

Sigh. I'm slow, sorry - I only just realized that if you return kTopCenter
instead of kNoArrow here, you should be good without modifying
BaseBubbleController.

[hcarmona, 2015/04/13 21:13:24]

We should return kNoArrow to avoid having an arrow pointing at the top of the
window.

+}