Center permission bubble if location bar is hidden in MacOS.

chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h"
 
 #import "chrome/browser/ui/cocoa/base_bubble_controller.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
 #import "chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h"
@@ skipping 45 matching lines @@
   // TODO(gbillock): implement. Should return true if the mouse is not over the
   // dialog.
   return false;
 }
 
 void PermissionBubbleCocoa::OnBubbleClosing() {
   bubbleController_ = nil;
 }
 
 NSPoint PermissionBubbleCocoa::GetAnchorPoint() {
-  LocationBarViewMac* location_bar =
-      [[parent_window_ windowController] locationBarBridge];
-  DCHECK(location_bar);
-  NSPoint anchor = location_bar->GetPageInfoBubblePoint();
+  NSPoint anchor;
+  if (HasLocationBar()) {
+    LocationBarViewMac* location_bar =
+        [[parent_window_ windowController] locationBarBridge];
+    DCHECK(location_bar);
+    anchor = location_bar->GetPageInfoBubblePoint();
+  } else {
+    // Center the bubble if there's no location bar.
+    NSView* content_view = parent_window_.contentView;
+    anchor.y = content_view.frame.size.height;
+    anchor.x = (content_view.frame.size.width) / 2;
+  }
+
   return [parent_window_ convertBaseToScreen:anchor];
 }
 
 NSWindow* PermissionBubbleCocoa::window() {
   return [bubbleController_ window];
 }
 
 void PermissionBubbleCocoa::SwitchParentWindow(NSWindow* parent) {
   parent_window_ = parent;
 }
+
+bool PermissionBubbleCocoa::HasLocationBar() {
+  LocationBarViewMac* location_bar =
+      [[parent_window_ windowController] locationBarBridge];
+  if (location_bar) {

[groby-ooo-7-16, 2015/04/01 00:19:14]

Please add a comment why even if we have a location bar, we need to test for a
feature as well.

[hcarmona, 2015/04/02 01:30:14]

Done.

+    return location_bar->browser()->SupportsWindowFeature(
+        Browser::FEATURE_LOCATIONBAR);
+  }
+  return false;
+}
+
+info_bubble::BubbleArrowLocation PermissionBubbleCocoa::GetArrowLocation() {
+  return HasLocationBar() ? info_bubble::kTopLeft : info_bubble::kNoArrow;
+}