Delete v8::HeapGraphNode::GetHeapValue

Delete v8::HeapGraphNode::GetHeapValue

BUG=chromium:324769
LOG=N
R=hpayer@chromium.org, mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=18404

[Michael Starzinger, 2013-12-09 09:49:49]

LGTM.

[Hannes Payer (out of office), 2013-12-09 18:52:43]

LGTM

[yurys, 2013-12-18 07:50:38]

Sven, would it make sense to delete deprecated method here following your advise
in another review (https://codereview.chromium.org/117353002/#msg4) ?

[Sven Panne, 2013-12-18 08:27:59]

On 2013/12/18 07:50:38, yurys wrote:
> Sven, would it make sense to delete deprecated method here following your
advise
> in another review (https://codereview.chromium.org/117353002/#msg4) ?

I think so, especially if there is a relatively straightforward replacement.
Let's aim for a deprecation-free next release...

[Sven Panne, 2013-12-18 08:32:15]

On 2013/12/18 08:27:59, Sven Panne wrote:
> On 2013/12/18 07:50:38, yurys wrote:
> > Sven, would it make sense to delete deprecated method here following your
> advise
> > in another review (https://codereview.chromium.org/117353002/#msg4) ?
> 
> I think so, especially if there is a relatively straightforward replacement.
> Let's aim for a deprecation-free next release...

Hmmmm:

svenpanne@svenpanne[master]:~/chromium/src$ gclient grep GetHeapValue
src/third_party/WebKit/Source/bindings/v8/ScriptProfiler.cpp :    
v8::Handle<v8::Value> value = node->GetHeapValue();

It looks like Chrome needs some tweaking before you can remove this.

[yurys, 2013-12-18 08:33:37]

On 2013/12/18 08:32:15, Sven Panne wrote:
> On 2013/12/18 08:27:59, Sven Panne wrote:
> > On 2013/12/18 07:50:38, yurys wrote:
> > > Sven, would it make sense to delete deprecated method here following your
> > advise
> > > in another review (https://codereview.chromium.org/117353002/#msg4) ?
> > 
> > I think so, especially if there is a relatively straightforward replacement.
> > Let's aim for a deprecation-free next release...
> 
> Hmmmm:
> 
> svenpanne@svenpanne[master]:~/chromium/src$ gclient grep GetHeapValue
> src/third_party/WebKit/Source/bindings/v8/ScriptProfiler.cpp :    
> v8::Handle<v8::Value> value = node->GetHeapValue();
> 
> It looks like Chrome needs some tweaking before you can remove this.

Yes, it does. It depends on https://codereview.chromium.org/104313002/ which in
turn depends on change in V8 which I just landed
(https://codereview.chromium.org/93843004/)

[yurys, 2013-12-18 08:35:00]

My plan was to wait until after next V8 roll, land Chromium side change and
after that land this CL, wdyt?

[Sven Panne, 2013-12-18 08:53:11]

On 2013/12/18 08:35:00, yurys wrote:
> My plan was to wait until after next V8 roll, land Chromium side change and
> after that land this CL, wdyt?

We just rolled, and I am not sure when we will roll again. If you like, you can
wait, of course. OTOH, you'll have to Chrome first, anyway, and I think it's OK
to do this now after the branch.

[yurys, 2013-12-23 09:33:26]

Committed patchset #2 manually as r18404 (presubmit successful).