Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: src/mips/ic-mips.cc

Issue 98633005: Bug in StoreIC::GenerateMegamorphic: strict_mode/extra_ic_state mismatch. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Verbal comment responses. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic.h ('k') | src/x64/ic-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1496 matching lines...) Expand 10 before | Expand all | Expand 10 after
1507 // The slow case calls into the runtime to complete the store without causing 1507 // The slow case calls into the runtime to complete the store without causing
1508 // an IC miss that would otherwise cause a transition to the generic stub. 1508 // an IC miss that would otherwise cause a transition to the generic stub.
1509 ExternalReference ref = 1509 ExternalReference ref =
1510 ExternalReference(IC_Utility(kKeyedStoreIC_Slow), masm->isolate()); 1510 ExternalReference(IC_Utility(kKeyedStoreIC_Slow), masm->isolate());
1511 1511
1512 __ TailCallExternalReference(ref, 3, 1); 1512 __ TailCallExternalReference(ref, 3, 1);
1513 } 1513 }
1514 1514
1515 1515
1516 void StoreIC::GenerateMegamorphic(MacroAssembler* masm, 1516 void StoreIC::GenerateMegamorphic(MacroAssembler* masm,
1517 StrictModeFlag strict_mode) { 1517 ExtraICState extra_ic_state) {
1518 // ----------- S t a t e ------------- 1518 // ----------- S t a t e -------------
1519 // -- a0 : value 1519 // -- a0 : value
1520 // -- a1 : receiver 1520 // -- a1 : receiver
1521 // -- a2 : name 1521 // -- a2 : name
1522 // -- ra : return address 1522 // -- ra : return address
1523 // ----------------------------------- 1523 // -----------------------------------
1524 1524
1525 // Get the receiver from the stack and probe the stub cache. 1525 // Get the receiver from the stack and probe the stub cache.
1526 Code::Flags flags = Code::ComputeFlags( 1526 Code::Flags flags = Code::ComputeFlags(
1527 Code::HANDLER, MONOMORPHIC, strict_mode, 1527 Code::HANDLER, MONOMORPHIC, extra_ic_state,
1528 Code::NORMAL, Code::STORE_IC); 1528 Code::NORMAL, Code::STORE_IC);
1529 masm->isolate()->stub_cache()->GenerateProbe( 1529 masm->isolate()->stub_cache()->GenerateProbe(
1530 masm, flags, a1, a2, a3, t0, t1, t2); 1530 masm, flags, a1, a2, a3, t0, t1, t2);
1531 1531
1532 // Cache miss: Jump to runtime. 1532 // Cache miss: Jump to runtime.
1533 GenerateMiss(masm); 1533 GenerateMiss(masm);
1534 } 1534 }
1535 1535
1536 1536
1537 void StoreIC::GenerateMiss(MacroAssembler* masm) { 1537 void StoreIC::GenerateMiss(MacroAssembler* masm) {
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
1685 } else { 1685 } else {
1686 ASSERT(Assembler::IsBne(branch_instr)); 1686 ASSERT(Assembler::IsBne(branch_instr));
1687 patcher.ChangeBranchCondition(eq); 1687 patcher.ChangeBranchCondition(eq);
1688 } 1688 }
1689 } 1689 }
1690 1690
1691 1691
1692 } } // namespace v8::internal 1692 } } // namespace v8::internal
1693 1693
1694 #endif // V8_TARGET_ARCH_MIPS 1694 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ic.h ('k') | src/x64/ic-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698