Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/ia32/ic-ia32.cc

Issue 98633005: Bug in StoreIC::GenerateMegamorphic: strict_mode/extra_ic_state mismatch. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Verbal comment responses. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/builtins.cc ('k') | src/ic.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1417 matching lines...) Expand 10 before | Expand all | Expand 10 after
1428 __ push(edx); // receiver 1428 __ push(edx); // receiver
1429 __ push(ecx); // name 1429 __ push(ecx); // name
1430 __ push(ebx); // return address 1430 __ push(ebx); // return address
1431 1431
1432 // Perform tail call to the entry. 1432 // Perform tail call to the entry.
1433 __ TailCallRuntime(Runtime::kKeyedGetProperty, 2, 1); 1433 __ TailCallRuntime(Runtime::kKeyedGetProperty, 2, 1);
1434 } 1434 }
1435 1435
1436 1436
1437 void StoreIC::GenerateMegamorphic(MacroAssembler* masm, 1437 void StoreIC::GenerateMegamorphic(MacroAssembler* masm,
1438 StrictModeFlag strict_mode) { 1438 ExtraICState extra_ic_state) {
1439 // ----------- S t a t e ------------- 1439 // ----------- S t a t e -------------
1440 // -- eax : value 1440 // -- eax : value
1441 // -- ecx : name 1441 // -- ecx : name
1442 // -- edx : receiver 1442 // -- edx : receiver
1443 // -- esp[0] : return address 1443 // -- esp[0] : return address
1444 // ----------------------------------- 1444 // -----------------------------------
1445
1446 Code::Flags flags = Code::ComputeFlags( 1445 Code::Flags flags = Code::ComputeFlags(
1447 Code::HANDLER, MONOMORPHIC, strict_mode, 1446 Code::HANDLER, MONOMORPHIC, extra_ic_state,
1448 Code::NORMAL, Code::STORE_IC); 1447 Code::NORMAL, Code::STORE_IC);
1449 masm->isolate()->stub_cache()->GenerateProbe( 1448 masm->isolate()->stub_cache()->GenerateProbe(
1450 masm, flags, edx, ecx, ebx, no_reg); 1449 masm, flags, edx, ecx, ebx, no_reg);
1451 1450
1452 // Cache miss: Jump to runtime. 1451 // Cache miss: Jump to runtime.
1453 GenerateMiss(masm); 1452 GenerateMiss(masm);
1454 } 1453 }
1455 1454
1456 1455
1457 void StoreIC::GenerateMiss(MacroAssembler* masm) { 1456 void StoreIC::GenerateMiss(MacroAssembler* masm) {
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
1677 Condition cc = (check == ENABLE_INLINED_SMI_CHECK) 1676 Condition cc = (check == ENABLE_INLINED_SMI_CHECK)
1678 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 1677 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
1679 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 1678 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
1680 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1679 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1681 } 1680 }
1682 1681
1683 1682
1684 } } // namespace v8::internal 1683 } } // namespace v8::internal
1685 1684
1686 #endif // V8_TARGET_ARCH_IA32 1685 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/builtins.cc ('k') | src/ic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698