Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 986303002: Re-enable child account detection, now behind a flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: strings Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2174 matching lines...) Expand 10 before | Expand all | Expand 10 after
2185 }, 2185 },
2186 { 2186 {
2187 "use-sync-sandbox", 2187 "use-sync-sandbox",
2188 IDS_FLAGS_SYNC_SANDBOX_NAME, 2188 IDS_FLAGS_SYNC_SANDBOX_NAME,
2189 IDS_FLAGS_SYNC_SANDBOX_DESCRIPTION, 2189 IDS_FLAGS_SYNC_SANDBOX_DESCRIPTION,
2190 kOsAll, 2190 kOsAll,
2191 SINGLE_VALUE_TYPE_AND_VALUE( 2191 SINGLE_VALUE_TYPE_AND_VALUE(
2192 switches::kSyncServiceURL, 2192 switches::kSyncServiceURL,
2193 "https://chrome-sync.sandbox.google.com/chrome-sync/alpha") 2193 "https://chrome-sync.sandbox.google.com/chrome-sync/alpha")
2194 }, 2194 },
2195 {
2196 "enable-child-account-detection",
2197 IDS_FLAGS_CHILD_ACCOUNT_DETECTION_NAME,
2198 IDS_FLAGS_CHILD_ACCOUNT_DETECTION_DESCRIPTION,
2199 kOsMac | kOsWin | kOsLinux | kOsCrOS,
Bernhard Bauer 2015/03/09 11:08:53 For consistency, we should probably add the flag o
Marc Treib 2015/03/09 11:20:12 But for now, it won't do anything on Android (righ
Bernhard Bauer 2015/03/09 14:02:51 That code is upstreamed now! :) The logic is in Ja
Marc Treib 2015/03/09 14:48:02 Right, awesome :) Done!
2200 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableChildAccountDetection,
2201 switches::kDisableChildAccountDetection)
2202 },
2195 2203
2196 // NOTE: Adding new command-line switches requires adding corresponding 2204 // NOTE: Adding new command-line switches requires adding corresponding
2197 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2205 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2198 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2206 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2199 }; 2207 };
2200 2208
2201 const Experiment* experiments = kExperiments; 2209 const Experiment* experiments = kExperiments;
2202 size_t num_experiments = arraysize(kExperiments); 2210 size_t num_experiments = arraysize(kExperiments);
2203 2211
2204 // Stores and encapsulates the little state that about:flags has. 2212 // Stores and encapsulates the little state that about:flags has.
(...skipping 583 matching lines...) Expand 10 before | Expand all | Expand 10 after
2788 } 2796 }
2789 2797
2790 const Experiment* GetExperiments(size_t* count) { 2798 const Experiment* GetExperiments(size_t* count) {
2791 *count = num_experiments; 2799 *count = num_experiments;
2792 return experiments; 2800 return experiments;
2793 } 2801 }
2794 2802
2795 } // namespace testing 2803 } // namespace testing
2796 2804
2797 } // namespace about_flags 2805 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698