[turbofan] Minor cleanup for JSGenericLowering.

[turbofan] Minor cleanup for JSGenericLowering.

Include what you use, and move implementation details to .cc file.

R=svenpanne@chromium.org

Committed: https://chromium.googlesource.com/v8/v8/+/5abc724e82af7714fdd54da4a124f3316e3dbb65

[Benedikt Meurer, 2015-03-09 05:13:00]

PTAL

[Sven Panne, 2015-03-09 08:07:03]

https://codereview.chromium.org/986243002/diff/1/src/compiler/js-generic-lowe...
File src/compiler/js-generic-lowering.h (right):

https://codereview.chromium.org/986243002/diff/1/src/compiler/js-generic-lowe...
src/compiler/js-generic-lowering.h:28: : is_typing_enabled_(is_typing_enabled),
jsgraph_(jsgraph) {}
Why is this suddenly inline? I think both the constructor and the destructor
should be defined in the .cc file to avoid code bloat (note that we are a
derived class, so the amount of code even for an empty constrcutor/destructor
can be huge).

[Benedikt Meurer, 2015-03-09 08:14:08]

https://codereview.chromium.org/986243002/diff/1/src/compiler/js-generic-lowe...
File src/compiler/js-generic-lowering.h (right):

https://codereview.chromium.org/986243002/diff/1/src/compiler/js-generic-lowe...
src/compiler/js-generic-lowering.h:28: : is_typing_enabled_(is_typing_enabled),
jsgraph_(jsgraph) {}
Well, this one is OK, because Reducer has an empty constructor. This is just
cleanup to make the constructor consistent with the inline destructor below.

[Sven Panne, 2015-03-09 08:17:32]

On 2015/03/09 08:14:08, Benedikt Meurer wrote:
> Well, this one is OK, because Reducer has an empty constructor. This is just
> cleanup to make the constructor consistent with the inline destructor below.

Then make it consistent by outlining both. :-)

[Benedikt Meurer, 2015-03-09 08:18:50]

Done.

[Sven Panne, 2015-03-09 09:49:09]

The CQ bit was checked by svenpanne@chromium.org

[Sven Panne, 2015-03-09 09:49:10]

lgtm

[commit-bot: I haz the power, 2015-03-09 09:49:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/986243002/20001

[commit-bot: I haz the power, 2015-03-09 09:53:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-09 09:53:48]

Failed to apply the patch.

[commit-bot: I haz the power, 2015-03-09 10:08:12]

Patchset 2 (id:??) landed as
https://crrev.com/5abc724e82af7714fdd54da4a124f3316e3dbb65
Cr-Commit-Position: refs/heads/master@{#27062}

[Benedikt Meurer, 2015-03-09 10:08:12]

Committed patchset #2 (id:20001) manually as
5abc724e82af7714fdd54da4a124f3316e3dbb65 (presubmit successful).