third_party/libaddressinput/libaddressinput.gyp - Issue 98623005: rAc i18n: implement storage interface for libaddressinput

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libaddressinput/libaddressinput.gyp

Issue 98623005: rAc i18n: implement storage interface for libaddressinput (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add forgotten file Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/libaddressinput/chromium/cpp/test/storage_test_runner.cc ('K') | « third_party/libaddressinput/chromium/cpp/test/storage_test_runner.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/libaddressinput/libaddressinput.gyp

diff --git a/third_party/libaddressinput/libaddressinput.gyp b/third_party/libaddressinput/libaddressinput.gyp

index 16e9f68cfcb52923bb60e95926510611ec137791..db85424e0b46aa285c9bcac25199f3392e3ef3af 100644

--- a/third_party/libaddressinput/libaddressinput.gyp

+++ b/third_party/libaddressinput/libaddressinput.gyp

@@ -49,6 +49,8 @@

'<(SHARED_INTERMEDIATE_DIR)/libaddressinput/',

'sources': [

+ 'chromium/chrome_storage_impl.cc',

+ 'chromium/chrome_storage_impl.h',

'chromium/json.cc',

'<(libaddressinput_dir)/cpp/include/libaddressinput/address_data.h',

'<(libaddressinput_dir)/cpp/include/libaddressinput/address_field.h',

@@ -117,6 +119,9 @@

'<(SHARED_INTERMEDIATE_DIR)/libaddressinput/',

'sources': [

+ 'chromium/chrome_storage_impl.cc',

+ 'chromium/chrome_storage_impl.h',

+ 'chromium/chrome_storage_impl_test.cc',

'<(libaddressinput_dir)/cpp/test/address_field_util_test.cc',

'<(libaddressinput_dir)/cpp/test/address_ui_test.cc',

'<(libaddressinput_dir)/cpp/test/fake_downloader.cc',

@@ -131,6 +136,8 @@

'<(libaddressinput_dir)/cpp/test/retriever_test.cc',

'<(libaddressinput_dir)/cpp/test/rule_retriever_test.cc',

'<(libaddressinput_dir)/cpp/test/rule_test.cc',

+ '<(libaddressinput_dir)/cpp/test/storage_test_runner.cc',

please use gerrit instead 2013/12/20 02:04:40 Also please add 'test/storage_test_runner.cc' to s

Evan Stade 2013/12/20 03:21:56 Done.

+ '<(libaddressinput_dir)/cpp/test/storage_test_runner.h',

'<(libaddressinput_dir)/cpp/test/util/json_test.cc',

'<(libaddressinput_dir)/cpp/test/util/md5_unittest.cc',

'<(libaddressinput_dir)/cpp/test/util/scoped_ptr_unittest.cc',

@@ -144,6 +151,7 @@

'dependencies': [

'libaddressinput',

+ '<(DEPTH)/base/base.gyp:base_prefs',

'<(DEPTH)/base/base.gyp:run_all_unittests',

'<(DEPTH)/testing/gtest.gyp:gtest',