Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Unified Diff: base/prefs/value_map_pref_store.h

Issue 98623005: rAc i18n: implement storage interface for libaddressinput (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: scopedvector Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/prefs/persistent_pref_store.h ('k') | base/prefs/value_map_pref_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/prefs/value_map_pref_store.h
diff --git a/base/prefs/value_map_pref_store.h b/base/prefs/value_map_pref_store.h
index 21e4b88817539122f3124f78502328f9fd9c77ad..29d0b382edfb0b6e71463072bf713ea0039bc588 100644
--- a/base/prefs/value_map_pref_store.h
+++ b/base/prefs/value_map_pref_store.h
@@ -11,12 +11,12 @@
#include "base/basictypes.h"
#include "base/observer_list.h"
#include "base/prefs/base_prefs_export.h"
-#include "base/prefs/pref_store.h"
#include "base/prefs/pref_value_map.h"
+#include "base/prefs/writeable_pref_store.h"
// A basic PrefStore implementation that uses a simple name-value map for
// storing the preference values.
-class BASE_PREFS_EXPORT ValueMapPrefStore : public PrefStore {
+class BASE_PREFS_EXPORT ValueMapPrefStore : public WriteablePrefStore {
public:
ValueMapPrefStore();
@@ -27,17 +27,13 @@ class BASE_PREFS_EXPORT ValueMapPrefStore : public PrefStore {
virtual void RemoveObserver(PrefStore::Observer* observer) OVERRIDE;
virtual bool HasObservers() const OVERRIDE;
+ // WriteablePrefStore overrides:
+ virtual void SetValue(const std::string& key, base::Value* value) OVERRIDE;
+ virtual void RemoveValue(const std::string& key) OVERRIDE;
+
protected:
virtual ~ValueMapPrefStore();
- // Store a |value| for |key| in the store. Also generates an notification if
- // the value changed. Assumes ownership of |value|, which must be non-NULL.
- void SetValue(const std::string& key, base::Value* value);
-
- // Remove the value for |key| from the store. Sends a notification if there
- // was a value to be removed.
- void RemoveValue(const std::string& key);
-
// Notify observers about the initialization completed event.
void NotifyInitializationCompleted();
« no previous file with comments | « base/prefs/persistent_pref_store.h ('k') | base/prefs/value_map_pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698