rAc i18n: implement storage interface for libaddressinput

third_party/libaddressinput/chromium/chrome_storage_impl_test.cc

 // Copyright (C) 2013 Google Inc.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 // http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.

[please use gerrit instead, 2013/12/20 02:04:40]

Use Chrome's license/copyright header, please.

[Evan Stade, 2013/12/20 03:21:56]

Done.

 
-#include "fake_storage.h"
+#include "chrome_storage_impl.h"
 
-#include <map>
 #include <string>
 
+#include <gtest/gtest.h>

[please use gerrit instead, 2013/12/20 02:04:40]

Since this code is not part of libaddressinput, then you should use Chrome's
include style (by specifying the full path to gtest.h under src/).

[Evan Stade, 2013/12/20 03:21:56]

Done.

also changed the name of this file to match chrome convention.

+
+#include "base/prefs/value_map_pref_store.h"
+#include "cpp/test/storage_test_runner.h"
+
 namespace i18n {
 namespace addressinput {
 
-FakeStorage::FakeStorage() {}
+namespace {
 
-FakeStorage::~FakeStorage() {}
+// Tests for ChromeStorageImpl object.
+class ChromeStorageImplTest : public testing::Test {
+ protected:
+  ChromeStorageImplTest()
+      : store_(new ValueMapPrefStore()),
+        storage_(store_.get()),
+        runner_(&storage_) {}
 
-void FakeStorage::Put(const std::string& key, const std::string& data) {
-  data_[key] = data;
+  virtual ~ChromeStorageImplTest() {}
+
+  scoped_refptr<ValueMapPrefStore> store_;
+  ChromeStorageImpl storage_;
+  StorageTestRunner runner_;
+};
+
+TEST_F(ChromeStorageImplTest, StandardStorageTests) {
+  EXPECT_NO_FATAL_FAILURE(runner_.RunAllTests());
 }
 
-void FakeStorage::Get(const std::string& key,
-                      scoped_ptr<Callback> data_ready) const {
-  std::map<std::string, std::string>::const_iterator data_it = data_.find(key);
-  bool success = data_it != data_.end();
-  std::string data = success ? data_it->second : std::string();
-  (*data_ready)(success, key, data);
-}
+}  // namespace
 
 }  // namespace addressinput
 }  // namespace i18n