tools/gn: Convert for loops to use the new range-based loops in C++11.

tools/gn/escape.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/escape.h"
 
 #include "base/containers/stack_container.h"
 #include "base/logging.h"
 
 namespace {
@@ skipping 26 matching lines @@
   if (ch == '$' || ch == ' ' || ch == ':')
     dest->push_back('$');
   dest->push_back(ch);
 }
 
 template<typename DestString>
 void EscapeStringToString_Ninja(const base::StringPiece& str,
                                 const EscapeOptions& options,
                                 DestString* dest,
                                 bool* needed_quoting) {
-  for (size_t i = 0; i < str.size(); i++)
-    NinjaEscapeChar(str[i], dest);
+  for (auto& elem : str)

[scottmg, 2015/03/13 19:58:30]

const?

[tfarina, 2015/03/13 23:27:49]

Done.

+    NinjaEscapeChar(elem, dest);
 }
 
 template<typename DestString>
 void EscapeStringToString_NinjaPreformatted(const base::StringPiece& str,
                                             DestString* dest) {
   // Only Ninja-escape $.
-  for (size_t i = 0; i < str.size(); i++) {
-    if (str[i] == '$')
+  for (auto& elem : str) {

[scottmg, 2015/03/13 19:58:30]

const?

[tfarina, 2015/03/13 23:27:49]

Done.

+    if (elem == '$')
       dest->push_back('$');
-    dest->push_back(str[i]);
+    dest->push_back(elem);
   }
 }
 
 // Escape for CommandLineToArgvW and additionally escape Ninja characters.
 //
 // The basic algorithm is if the string doesn't contain any parse-affecting
 // characters, don't do anything (other than the Ninja processing). If it does,
 // quote the string, and backslash-escape all quotes and backslashes.
 // See:
 //   http://blogs.msdn.com/b/twistylittlepassagesallalike/archive/2011/04/23/everyone-quotes-arguments-the-wrong-way.aspx
@@ skipping 42 matching lines @@
     if (needed_quoting)
       *needed_quoting = true;
   }
 }
 
 template<typename DestString>
 void EscapeStringToString_PosixNinjaFork(const base::StringPiece& str,
                                          const EscapeOptions& options,
                                          DestString* dest,
                                          bool* needed_quoting) {
-  for (size_t i = 0; i < str.size(); i++) {
-    if (str[i] == '$' || str[i] == ' ') {
+  for (auto& elem : str) {

[scottmg, 2015/03/13 19:58:30]

const?

[tfarina, 2015/03/13 23:27:49]

Done.

+    if (elem == '$' || elem == ' ') {
       // Space and $ are special to both Ninja and the shell. '$' escape for
       // Ninja, then backslash-escape for the shell.
       dest->push_back('\\');
       dest->push_back('$');
-      dest->push_back(str[i]);
-    } else if (str[i] == ':') {
+      dest->push_back(elem);
+    } else if (elem == ':') {
       // Colon is the only other Ninja special char, which is not special to
       // the shell.
       dest->push_back('$');
       dest->push_back(':');
-    } else if (static_cast<unsigned>(str[i]) >= 0x80 ||
-               !kShellValid[static_cast<int>(str[i])]) {
+    } else if (static_cast<unsigned>(elem) >= 0x80 ||
+               !kShellValid[static_cast<int>(elem)]) {
       // All other invalid shell chars get backslash-escaped.
       dest->push_back('\\');
-      dest->push_back(str[i]);
+      dest->push_back(elem);
     } else {
       // Everything else is a literal.
-      dest->push_back(str[i]);
+      dest->push_back(elem);
     }
   }
 }
 
 template<typename DestString>
 void EscapeStringToString(const base::StringPiece& str,
                           const EscapeOptions& options,
                           DestString* dest,
                           bool* needed_quoting) {
   switch (options.mode) {
@@ skipping 46 matching lines @@
 }
 
 void EscapeStringToStream(std::ostream& out,
                           const base::StringPiece& str,
                           const EscapeOptions& options) {
   base::StackString<256> escaped;
   EscapeStringToString(str, options, &escaped.container(), nullptr);
   if (!escaped->empty())
     out.write(escaped->data(), escaped->size());
 }