Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Side by Side Diff: tools/gn/operators.cc

Issue 986113002: tools/gn: Convert for loops to use the new range-based loops in C++11. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more fixes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tools/gn/operators.h" 5 #include "tools/gn/operators.h"
6 6
7 #include "base/strings/string_number_conversions.h" 7 #include "base/strings/string_number_conversions.h"
8 #include "tools/gn/err.h" 8 #include "tools/gn/err.h"
9 #include "tools/gn/parse_tree.h" 9 #include "tools/gn/parse_tree.h"
10 #include "tools/gn/scope.h" 10 #include "tools/gn/scope.h"
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 } 91 }
92 if (!found_match) { 92 if (!found_match) {
93 *err = Err(to_remove.origin()->GetRange(), "Item not found", 93 *err = Err(to_remove.origin()->GetRange(), "Item not found",
94 "You were trying to remove " + to_remove.ToString(true) + 94 "You were trying to remove " + to_remove.ToString(true) +
95 "\nfrom the list but it wasn't there."); 95 "\nfrom the list but it wasn't there.");
96 } 96 }
97 break; 97 break;
98 } 98 }
99 99
100 case Value::LIST: // Filter out each individual thing. 100 case Value::LIST: // Filter out each individual thing.
101 for (size_t i = 0; i < to_remove.list_value().size(); i++) { 101 for (const auto& elem : to_remove.list_value()) {
102 // TODO(brettw) if the nested item is a list, we may want to search 102 // TODO(brettw) if the nested item is a list, we may want to search
103 // for the literal list rather than remote the items in it. 103 // for the literal list rather than remote the items in it.
104 RemoveMatchesFromList(op_node, list, to_remove.list_value()[i], err); 104 RemoveMatchesFromList(op_node, list, elem, err);
105 if (err->has_error()) 105 if (err->has_error())
106 return; 106 return;
107 } 107 }
108 break; 108 break;
109 109
110 default: 110 default:
111 break; 111 break;
112 } 112 }
113 } 113 }
114 114
(...skipping 461 matching lines...) Expand 10 before | Expand all | Expand 10 after
576 return ExecuteGreaterEquals(scope, op_node, left_value, right_value, err); 576 return ExecuteGreaterEquals(scope, op_node, left_value, right_value, err);
577 if (op.type() == Token::LESS_EQUAL) 577 if (op.type() == Token::LESS_EQUAL)
578 return ExecuteLessEquals(scope, op_node, left_value, right_value, err); 578 return ExecuteLessEquals(scope, op_node, left_value, right_value, err);
579 if (op.type() == Token::GREATER_THAN) 579 if (op.type() == Token::GREATER_THAN)
580 return ExecuteGreater(scope, op_node, left_value, right_value, err); 580 return ExecuteGreater(scope, op_node, left_value, right_value, err);
581 if (op.type() == Token::LESS_THAN) 581 if (op.type() == Token::LESS_THAN)
582 return ExecuteLess(scope, op_node, left_value, right_value, err); 582 return ExecuteLess(scope, op_node, left_value, right_value, err);
583 583
584 return Value(); 584 return Value();
585 } 585 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698