Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 986103002: DM: allow SKPs to be smaller than 1000x1000 (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM: allow SKPs to be smaller than 1000x1000 This sniffs the .skp dimensions and intersects them with our 1000x1000 viewport. This fixes things like desk_carsvg.skp, which is only 902 pixels tall. In 565 now, the remaining 98 pixels draw as black, which looks funny and is confusing to triage. No apparent affect on DM memory usage. (We're about to map the file anyway.) BUG=skia: Committed: https://skia.googlesource.com/skia/+/ffa901aa7e360ed5115a0955221f4c2d2632d418

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M dm/DMSrcSink.cpp View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mtklein_C
5 years, 9 months ago (2015-03-08 17:24:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986103002/1
5 years, 9 months ago (2015-03-08 17:24:57 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-08 17:24:58 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 9 months ago (2015-03-08 23:24:58 UTC) #7
hal.canary
lgtm
5 years, 9 months ago (2015-03-16 16:32:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986103002/1
5 years, 9 months ago (2015-03-16 17:18:12 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 17:38:10 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ffa901aa7e360ed5115a0955221f4c2d2632d418

Powered by Google App Engine
This is Rietveld 408576698