Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 986033002: Allow Crashpad to build in the Chromium tree (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Allow Crashpad to build in the Chromium tree. When building in the Chromium tree, this swaps out Crashpad’s copies of mini_chromium, gtest, and gmock for the equivalents provided by Chromium. A GYP variable, crashpad_in_chromium, is used to determine the behavior. gclient doesn’t sync sub-DEPS, so when doing an in-Chromium build, Crashpad’s copies of mini_chromium, gtest, and gmock are not available. BUG=crashpad:12 R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/b665a0db075ee4449c09a0cee5ca4aebfb19e679

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Simpler -sectcreate #

Patch Set 4 : Rewrap #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+543 lines, -394 lines) Patch
A build/crashpad_in_chromium.gypi View 1 chunk +43 lines, -0 lines 0 comments Download
M build/gyp_crashpad.py View 1 chunk +1 line, -0 lines 0 comments Download
M client/client.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M handler/handler.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M snapshot/snapshot.gyp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/gmock/gmock.gyp View 1 2 3 1 chunk +197 lines, -167 lines 2 comments Download
M third_party/gtest/gtest.gyp View 1 1 chunk +236 lines, -206 lines 0 comments Download
A third_party/mini_chromium/mini_chromium.gyp View 1 chunk +46 lines, -0 lines 0 comments Download
M tools/tools.gyp View 1 2 7 chunks +7 lines, -8 lines 0 comments Download
M util/util.gyp View 1 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Mark Mentovai
5 years, 9 months ago (2015-03-07 19:21:48 UTC) #1
Mark Mentovai
5 years, 9 months ago (2015-03-07 19:22:48 UTC) #3
Robert Sesek
https://codereview.chromium.org/986033002/diff/60001/third_party/gmock/gmock.gyp File third_party/gmock/gmock.gyp (right): https://codereview.chromium.org/986033002/diff/60001/third_party/gmock/gmock.gyp#newcode201 third_party/gmock/gmock.gyp:201: '../../../../../testing/gmock.gyp:gmock', This would make moving the crashpad project in ...
5 years, 9 months ago (2015-03-09 18:37:19 UTC) #4
Mark Mentovai
https://codereview.chromium.org/986033002/diff/60001/third_party/gmock/gmock.gyp File third_party/gmock/gmock.gyp (right): https://codereview.chromium.org/986033002/diff/60001/third_party/gmock/gmock.gyp#newcode201 third_party/gmock/gmock.gyp:201: '../../../../../testing/gmock.gyp:gmock', Robert Sesek wrote: > This would make moving ...
5 years, 9 months ago (2015-03-09 19:18:09 UTC) #5
Robert Sesek
LGTM I guess, then
5 years, 9 months ago (2015-03-09 19:21:59 UTC) #6
Mark Mentovai
5 years, 9 months ago (2015-03-09 19:25:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
b665a0db075ee4449c09a0cee5ca4aebfb19e679 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698