Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 98603015: Add histograms for prerender rel types. (Closed)

Created:
7 years ago by gavinp
Modified:
6 years, 10 months ago
CC:
chromium-reviews, davidben+watch_chromium.org, cbentzel+watch_chromium.org, jar (doing other things), tburkard+watch_chromium.org, gavinp+prer_chromium.org, dominich+watch_chromium.org, asvitkine+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Add histograms for prerender rel types. Since we have an associated finch experiment, these two histograms should be good enough for us to catch information on the population of rel types of prerenders as added and run. R=tburkard@chromium.org,davidben@chromium.org,isherman@chromium.org BUG=329963 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250784

Patch Set 1 #

Patch Set 2 : actually report histogram, fix includes #

Patch Set 3 : move enumeration closer to first use #

Total comments: 1

Patch Set 4 : rebase to trunk #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1 line) Patch
M chrome/browser/prerender/prerender_link_manager.cc View 1 2 3 5 chunks +29 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +21 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
gavinp
David, Timo: PTAL. I split out the histograms from the rest to make life easier ...
7 years ago (2013-12-20 19:10:42 UTC) #1
gavinp
https://codereview.chromium.org/98603015/diff/70002/chrome/browser/prerender/prerender_link_manager.cc File chrome/browser/prerender/prerender_link_manager.cc (right): https://codereview.chromium.org/98603015/diff/70002/chrome/browser/prerender/prerender_link_manager.cc#newcode62 chrome/browser/prerender/prerender_link_manager.cc:62: enum RelTypeHistogramEnum { Our coding standard doesn't define an ...
7 years ago (2013-12-20 19:56:43 UTC) #2
davidben
LGTM. The bitmask enum feels pretty goofy, but I guess they have to be listed ...
6 years, 11 months ago (2014-01-02 19:30:26 UTC) #3
gavinp
+isherman isherman: PTAL for histograms.
6 years, 10 months ago (2014-02-07 20:37:38 UTC) #4
Ilya Sherman
histograms lgtm https://codereview.chromium.org/98603015/diff/540001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/98603015/diff/540001/tools/metrics/histograms/histograms.xml#newcode30017 tools/metrics/histograms/histograms.xml:30017: + <int value="3" label="PRERENDER_REL_TYPE_PRERENDER_AND_NEXT"/> Optional nit: These ...
6 years, 10 months ago (2014-02-07 21:32:58 UTC) #5
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 10 months ago (2014-02-12 17:08:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/98603015/540001
6 years, 10 months ago (2014-02-12 17:10:27 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 20:10:00 UTC) #8
Message was sent while issue was closed.
Change committed as 250784

Powered by Google App Engine
This is Rietveld 408576698