Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1564)

Unified Diff: content/browser/ppapi_plugin_process_host.cc

Issue 98603007: Launches a privileged utility process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolves review feedback. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/ppapi_plugin_process_host.cc
diff --git a/content/browser/ppapi_plugin_process_host.cc b/content/browser/ppapi_plugin_process_host.cc
index e42d549966f905e137395463608ba081fc18551e..b2b2728215a98793fe5bfd96e06f095e127e1fa8 100644
--- a/content/browser/ppapi_plugin_process_host.cc
+++ b/content/browser/ppapi_plugin_process_host.cc
@@ -326,6 +326,7 @@ bool PpapiPluginProcessHost::Init(const PepperPluginInfo& info) {
process_->Launch(
#if defined(OS_WIN)
new PpapiPluginSandboxedProcessLauncherDelegate(is_broker_),
+ false,
#elif defined(OS_POSIX)
use_zygote,
base::EnvironmentMap(),
@@ -355,7 +356,8 @@ void PpapiPluginProcessHost::RequestPluginChannel(Client* client) {
}
void PpapiPluginProcessHost::OnProcessLaunched() {
- host_impl_->set_plugin_process_handle(process_->GetHandle());
+ host_impl_->set_plugin_process_handle(
+ static_cast<ChildProcessHostDelegate*>(process_.get())->GetHandle());
jam 2014/02/01 01:09:10 I just noticed this and the other places that case
Drew Haven 2014/02/04 21:25:54 Okay, I sort of thought the same thing. But I did
}
void PpapiPluginProcessHost::OnProcessCrashed(int exit_code) {

Powered by Google App Engine
This is Rietveld 408576698