content/common/child_process_host_impl.cc - Issue 98603007: Launches a privileged utility process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/child_process_host_impl.cc

Issue 98603007: Launches a privileged utility process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Actually works now. Removes unnecessary logging. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/child_process_host_impl.cc

diff --git a/content/common/child_process_host_impl.cc b/content/common/child_process_host_impl.cc

index fb058d3ea987c73acc45b120de38a34ce9fafb9e..32e08049e93b1f46cd088b21c0adb071157a41f3 100644

--- a/content/common/child_process_host_impl.cc

+++ b/content/common/child_process_host_impl.cc

@@ -262,7 +262,10 @@ bool ChildProcessHostImpl::OnMessageReceived(const IPC::Message& msg) {

}

void ChildProcessHostImpl::OnChannelConnected(int32 peer_pid) {

- if (!base::OpenPrivilegedProcessHandle(peer_pid, &peer_handle_)) {

+ if (!peer_handle_) {

+ peer_handle_ = delegate_->GetHandle();

+ }

+ if (!peer_handle_ && !base::OpenPrivilegedProcessHandle(peer_pid, &peer_handle_)) {

NOTREACHED();

}

opening_channel_ = false;