Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: content/browser/browser_child_process_host_impl.h

Issue 98603007: Launches a privileged utility process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removes unnecessary casts, extra tests and cleans up launch.cc Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_child_process_host_impl.h
diff --git a/content/browser/browser_child_process_host_impl.h b/content/browser/browser_child_process_host_impl.h
index 6345595a14e275790c96c67c0fec7456ebf726e0..4e6c6e9c53af96a1a92e9d6afbc7f516d84184e7 100644
--- a/content/browser/browser_child_process_host_impl.h
+++ b/content/browser/browser_child_process_host_impl.h
@@ -45,6 +45,7 @@ class CONTENT_EXPORT BrowserChildProcessHostImpl
virtual void Launch(
#if defined(OS_WIN)
SandboxedProcessLauncherDelegate* delegate,
+ bool launch_elevated,
#elif defined(OS_POSIX)
bool use_zygote,
const base::EnvironmentMap& environ,
@@ -56,10 +57,7 @@ class CONTENT_EXPORT BrowserChildProcessHostImpl
bool known_dead, int* exit_code) OVERRIDE;
virtual void SetName(const string16& name) OVERRIDE;
virtual void SetHandle(base::ProcessHandle handle) OVERRIDE;
-
- // Returns the handle of the child process. This can be called only after
- // OnProcessLaunched is called or it will be invalid and may crash.
- base::ProcessHandle GetHandle() const;
+ virtual base::ProcessHandle GetHandle() const OVERRIDE;
jam 2014/02/04 23:29:06 sorry if I wasn't clear. since this is part of Chi
Drew Haven 2014/02/05 02:36:31 Ah, I see. We'll just make the whole implementati
// Removes this host from the host list. Calls ChildProcessHost::ForceShutdown
void ForceShutdown();
@@ -98,6 +96,7 @@ class CONTENT_EXPORT BrowserChildProcessHostImpl
// ChildProcessLauncher::Client implementation.
virtual void OnProcessLaunched() OVERRIDE;
+ virtual void OnProcessLaunchFailed() OVERRIDE;
#if defined(OS_WIN)
void DeleteProcessWaitableEvent(base::WaitableEvent* event);

Powered by Google App Engine
This is Rietveld 408576698