Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 986023003: Add dart_core.js (fixes #89) (Closed)

Created:
5 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 9 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add dart_core.js (fixes #89)

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M lib/src/dependency_graph.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/html_input.html View 1 chunk +1 line, -0 lines 0 comments Download
M test/codegen/expect/server_mode/html_input.html View 1 chunk +1 line, -0 lines 0 comments Download
M test/dependency_graph_test.dart View 22 chunks +22 lines, -0 lines 2 comments Download
M test/test.sh View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Siggi Cherem (dart-lang)
This should get rid of the need to copy the runtime folder to the out/dev_compiler/ ...
5 years, 9 months ago (2015-03-11 00:59:58 UTC) #3
vsm
lgtm https://codereview.chromium.org/986023003/diff/20001/test/dependency_graph_test.dart File test/dependency_graph_test.dart (right): https://codereview.chromium.org/986023003/diff/20001/test/dependency_graph_test.dart#newcode667 test/dependency_graph_test.dart:667: group('sever-mode', () { server-mode :-)
5 years, 9 months ago (2015-03-11 01:23:00 UTC) #4
Siggi Cherem (dart-lang)
https://codereview.chromium.org/986023003/diff/20001/test/dependency_graph_test.dart File test/dependency_graph_test.dart (right): https://codereview.chromium.org/986023003/diff/20001/test/dependency_graph_test.dart#newcode667 test/dependency_graph_test.dart:667: group('sever-mode', () { On 2015/03/11 01:23:00, vsm wrote: > ...
5 years, 9 months ago (2015-03-11 01:33:03 UTC) #5
Siggi Cherem (dart-lang)
5 years, 9 months ago (2015-03-11 01:34:47 UTC) #6
Message was sent while issue was closed.
submitted at
https://github.com/dart-lang/dev_compiler/commit/0e8ea7aad0cb7bce37d31d4c7126...

Powered by Google App Engine
This is Rietveld 408576698