linux/x11: Fix setting custom window shapes in High DPI.

linux/x11: Fix setting custom window shapes in High DPI.

Chrome Apps (e.g. hangouts etc.) can set a custom shape for the windows. Make
sure the shape is translated correctly in hidpi environment.

BUG=461120
R=pkotwicz@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/07bd36abf92fd84bffd6f2d8feb4532dfb77901a

[sadrul, 2015-03-08 02:27:37]

sadrul@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[pkotwicz, 2015-03-08 23:33:27]

LGTM

https://codereview.chromium.org/985993002/diff/1/ui/views/widget/desktop_aura...
File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right):

https://codereview.chromium.org/985993002/diff/1/ui/views/widget/desktop_aura...
ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:503: }
Move "window_shape_ = gfx::CreateRegionFromSkRegion(*native_region);" to an else
statement

[pkotwicz, 2015-03-08 23:44:58]

https://codereview.chromium.org/985993002/diff/1/ui/views/widget/desktop_aura...
File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right):

https://codereview.chromium.org/985993002/diff/1/ui/views/widget/desktop_aura...
ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:502: }
I getBoundaryPath() returns false, you can just do "window_shape_ =
XCreateRegion()". Alternatively, you can check !native_region->isEmpty() on line
496

I think both options are more readable

[pkotwicz, 2015-03-08 23:45:23]

If getBoundaryPath() returns false, you can just do "window_shape_ =
XCreateRegion()". Alternatively, you can check !native_region->isEmpty() on line
496

I think both options are more readable

[sadrul, 2015-03-09 17:20:10]

On 2015/03/08 23:45:23, pkotwicz wrote:
> If getBoundaryPath() returns false, you can just do "window_shape_ =
> XCreateRegion()". Alternatively, you can check !native_region->isEmpty() on
line
> 496
> 
> I think both options are more readable

I have done both (currently it looks like getBoundaryPath() returns false only
if the region is empty, so doing just one of these would probably be OK, but I
didn't want to depend on that internal behaviour, so did both).

https://codereview.chromium.org/985993002/diff/1/ui/views/widget/desktop_aura...
File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right):

https://codereview.chromium.org/985993002/diff/1/ui/views/widget/desktop_aura...
ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:502: }
On 2015/03/08 23:44:57, pkotwicz wrote:
> I getBoundaryPath() returns false, you can just do "window_shape_ =
> XCreateRegion()". Alternatively, you can check !native_region->isEmpty() on
line
> 496
> 
> I think both options are more readable

Done.

https://codereview.chromium.org/985993002/diff/1/ui/views/widget/desktop_aura...
ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:503: }
On 2015/03/08 23:33:26, pkotwicz wrote:
> Move "window_shape_ = gfx::CreateRegionFromSkRegion(*native_region);" to an
else
> statement

Done.

[commit-bot: I haz the power, 2015-03-09 18:29:03]

Patchset 2 (id:??) landed as
https://crrev.com/07bd36abf92fd84bffd6f2d8feb4532dfb77901a
Cr-Commit-Position: refs/heads/master@{#319695}

[sadrul, 2015-03-09 18:29:17]

Committed patchset #2 (id:20001) manually as
07bd36abf92fd84bffd6f2d8feb4532dfb77901a (presubmit successful).