Issue 985933004: Do cleanup instead of excluding runtime files in diff

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 985933004: Do cleanup instead of excluding runtime files in diff (Closed)

Created:
5 years, 9 months ago by Siggi Cherem (dart-lang)

Modified:
5 years, 9 months ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -16 lines)			Patch
M	.gitignore	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/codegen_test.dart	View	2 chunks	+44 lines, -7 lines	0 comments	Download
M	test/test.sh	View	2 chunks	+2 lines, -7 lines	0 comments	Download

Total messages: 5 (2 generated)

Siggi Cherem (dart-lang)

I went back and forth on this, but after thinking about your comment on the ...

5 years, 9 months ago (2015-03-12 00:34:05 UTC) #3

Siggi Cherem (dart-lang)

5 years, 9 months ago (2015-03-12 17:06:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:20001) manually as
387b268a00a74b2e597a2d9e03bc6b0591a9a044 (presubmit successful).