Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 985933002: bpf_dsl: switch PolicyCompiler from seccomp-bpf/die.h to base/logging.h (Closed)

Created:
5 years, 9 months ago by mdempsky
Modified:
5 years, 9 months ago
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bpf_dsl: switch PolicyCompiler from seccomp-bpf/die.h to base/logging.h [Reland of https://codereview.chromium.org/945743002] PolicyCompiler runs in a normal process context, so it doesn't require the extra low-levelness of SANDBOX_DIE. BUG=449357 Committed: https://crrev.com/0b7c0c442edced1ab10b0c5208d5d0998923cc17 Cr-Commit-Position: refs/heads/master@{#319563}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -44 lines) Patch
M sandbox/linux/bpf_dsl/policy_compiler.cc View 5 chunks +28 lines, -44 lines 0 comments Download
M sandbox/linux/bpf_dsl/trap_registry.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mdempsky
(Again, exact same as before.)
5 years, 9 months ago (2015-03-07 03:26:53 UTC) #2
jln (very slow on Chromium)
Rubberstamp lgtm, based on previous review.
5 years, 9 months ago (2015-03-07 03:39:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985933002/1
5 years, 9 months ago (2015-03-07 03:44:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 03:58:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985933002/1
5 years, 9 months ago (2015-03-07 21:45:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-07 23:01:10 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-07 23:02:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b7c0c442edced1ab10b0c5208d5d0998923cc17
Cr-Commit-Position: refs/heads/master@{#319563}

Powered by Google App Engine
This is Rietveld 408576698