Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 985893002: Revert of MSan: check data is initialized when serializing with base::Pickle. (Closed)

Created:
5 years, 9 months ago by Lei Zhang
Modified:
5 years, 9 months ago
Reviewers:
Nico, earthdok
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of MSan: check data is initialized when serializing with base::Pickle. (patchset #1 id:1 of https://codereview.chromium.org/988693004/) Reason for revert: Found errors w.r.t. IPC messages. Reverting for now while people fix the errors. Original issue's description: > MSan: check data is initialized when serializing with base::Pickle. > > Serialization implies that the data is going to leave the process one way or > another, and it's never a good idea to leak uninitialized bytes. In most cases > MSan would catch this later on (e.g. on a write()). There are exceptions to > that, however, such as writing to shared memory. It doesn't hurt to have an > extra check here. > > BUG=463906 > R=thakis@chromium.org > > Committed: https://crrev.com/2c705b038413d30d7aae5ff5d09882575e93c898 > Cr-Commit-Position: refs/heads/master@{#319459} TBR=thakis@chromium.org,earthdok@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463906 Committed: https://crrev.com/d74906086c38b72bed2017a772c67f3c3fde2709 Cr-Commit-Position: refs/heads/master@{#319510}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M base/compiler_specific.h View 1 chunk +2 lines, -10 lines 0 comments Download
M base/pickle.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
Created Revert of MSan: check data is initialized when serializing with base::Pickle.
5 years, 9 months ago (2015-03-06 21:34:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985893002/1
5 years, 9 months ago (2015-03-06 21:35:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 21:36:17 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d74906086c38b72bed2017a772c67f3c3fde2709 Cr-Commit-Position: refs/heads/master@{#319510}
5 years, 9 months ago (2015-03-06 21:37:12 UTC) #4
Nico
do you have a list of bugs?
5 years, 9 months ago (2015-03-06 21:38:05 UTC) #5
Lei Zhang
On 2015/03/06 21:38:05, Nico wrote: > do you have a list of bugs? I'll file ...
5 years, 9 months ago (2015-03-06 21:38:36 UTC) #6
Lei Zhang
On 2015/03/06 21:38:36, Lei Zhang wrote: > On 2015/03/06 21:38:05, Nico wrote: > > do ...
5 years, 9 months ago (2015-03-06 21:48:34 UTC) #7
Lei Zhang
On 2015/03/06 21:48:34, Lei Zhang wrote: > On 2015/03/06 21:38:36, Lei Zhang wrote: > > ...
5 years, 9 months ago (2015-03-07 04:16:52 UTC) #8
earthdok
On 2015/03/07 04:16:52, Lei Zhang wrote: > On 2015/03/06 21:48:34, Lei Zhang wrote: > > ...
5 years, 9 months ago (2015-03-10 14:37:09 UTC) #9
Lei Zhang
5 years, 9 months ago (2015-03-16 22:35:43 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1008393004/ by thestig@chromium.org.

The reason for reverting is: The bugs that caused the revert have been fixed -
Unreverting..

Powered by Google App Engine
This is Rietveld 408576698