Upstream TabTitleObserver

Upstream TabTitleObserver

This is a useful class in media playback tests.

BUG=147963
Committed: https://crrev.com/789f5d0f4ccb6dced9bd1c389a93535e8a0b125b
Cr-Commit-Position: refs/heads/master@{#320692}

[Changwan Ryu, 2015-03-12 06:24:29]

changwan@chromium.org changed reviewers:
+ qinmin@chromium.org, tedchoc@chromium.org

[Ted C, 2015-03-12 16:04:50]

https://codereview.chromium.org/985863003/diff/1/chrome/test/android/javatest...
File
chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabTitleObserver.java
(right):

https://codereview.chromium.org/985863003/diff/1/chrome/test/android/javatest...
chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabTitleObserver.java:15:
* This is useful in media playback tests to get notified of various playback
events.
This second line isn't necessary.  This is useful for anything that wants to
know when the title of a page matched the expectation, so no reason to mention
media tests here.

https://codereview.chromium.org/985863003/diff/1/chrome/test/android/javatest...
chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabTitleObserver.java:29:
});
What happens if the title already matches the expected title?

Should we be notifying the callback?

https://codereview.chromium.org/985863003/diff/1/chrome/test/android/javatest...
chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabTitleObserver.java:32:
public CallbackHelper getCallback() {
Does anyone ever need to wait on this multiple times?

If not, I would rather just expose the wait function from the callback helper
here and allow this class to maintain when it matches.

Also, that would allow for a cleaner handling if the tab title matches already.

[Changwan Ryu, 2015-03-13 07:08:37]

https://codereview.chromium.org/985863003/diff/1/chrome/test/android/javatest...
File
chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabTitleObserver.java
(right):

https://codereview.chromium.org/985863003/diff/1/chrome/test/android/javatest...
chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabTitleObserver.java:15:
* This is useful in media playback tests to get notified of various playback
events.
On 2015/03/12 16:04:50, Ted C wrote:
> This second line isn't necessary.  This is useful for anything that wants to
> know when the title of a page matched the expectation, so no reason to mention
> media tests here.

Done.

https://codereview.chromium.org/985863003/diff/1/chrome/test/android/javatest...
chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabTitleObserver.java:29:
});
On 2015/03/12 16:04:50, Ted C wrote:
> What happens if the title already matches the expected title?
> 
> Should we be notifying the callback?

Done.

https://codereview.chromium.org/985863003/diff/1/chrome/test/android/javatest...
chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabTitleObserver.java:32:
public CallbackHelper getCallback() {
On 2015/03/12 16:04:49, Ted C wrote:
> Does anyone ever need to wait on this multiple times?
> 
> If not, I would rather just expose the wait function from the callback helper
> here and allow this class to maintain when it matches.
> 
> Also, that would allow for a cleaner handling if the tab title matches
already.

Done.

[Ted C, 2015-03-13 16:18:20]

lgtm

https://codereview.chromium.org/985863003/diff/20001/chrome/test/android/java...
File
chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabTitleObserver.java
(right):

https://codereview.chromium.org/985863003/diff/20001/chrome/test/android/java...
chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabTitleObserver.java:35:
notifyCallbackIfTitleMatches(tab);
probably should make this return a boolean and only add the observer if it
doesn't match.

[Changwan Ryu, 2015-03-16 00:28:12]

https://codereview.chromium.org/985863003/diff/20001/chrome/test/android/java...
File
chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabTitleObserver.java
(right):

https://codereview.chromium.org/985863003/diff/20001/chrome/test/android/java...
chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabTitleObserver.java:35:
notifyCallbackIfTitleMatches(tab);
On 2015/03/13 16:18:20, Ted C wrote:
> probably should make this return a boolean and only add the observer if it
> doesn't match.

Done.

[Changwan Ryu, 2015-03-16 00:28:20]

The CQ bit was checked by changwan@chromium.org

[Changwan Ryu, 2015-03-16 00:28:20]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/985863003/#ps40001 (title:
"add observer only when not notified already")

[commit-bot: I haz the power, 2015-03-16 00:28:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/985863003/40001

[commit-bot: I haz the power, 2015-03-16 00:53:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-16 00:54:04]

Patchset 3 (id:??) landed as
https://crrev.com/789f5d0f4ccb6dced9bd1c389a93535e8a0b125b
Cr-Commit-Position: refs/heads/master@{#320692}