Move all protocol event matchers to test_event_matchers.h

Move all protocol event matchers to test_event_matchers.h

Committed: https://crrev.com/2933366b4368740e7b433021d945741ea04e1798
Cr-Commit-Position: refs/heads/master@{#320517}

[Rintaro Kuroiwa, 2015-03-07 00:46:28]

rkuroiwa@chromium.org changed reviewers:
+ wez@chromium.org

[Rintaro Kuroiwa, 2015-03-07 00:46:29]

Please take a look.

[Wez, 2015-03-12 00:13:58]

https://codereview.chromium.org/985863002/diff/130001/remoting/client/plugin/...
File remoting/client/plugin/normalizing_input_filter_cros_unittest.cc (left):

https://codereview.chromium.org/985863002/diff/130001/remoting/client/plugin/...
remoting/client/plugin/normalizing_input_filter_cros_unittest.cc:32: static
const uint32 kTestLockStates = protocol::KeyEvent::LOCK_STATES_NUMLOCK;
Why remove this?

https://codereview.chromium.org/985863002/diff/130001/remoting/client/plugin/...
File remoting/client/plugin/normalizing_input_filter_mac_unittest.cc (left):

https://codereview.chromium.org/985863002/diff/130001/remoting/client/plugin/...
remoting/client/plugin/normalizing_input_filter_mac_unittest.cc:29: static const
uint32 kTestLockStates = protocol::KeyEvent::LOCK_STATES_NUMLOCK;
And this?

https://codereview.chromium.org/985863002/diff/130001/remoting/protocol/test_...
File remoting/protocol/test_event_matchers.h (right):

https://codereview.chromium.org/985863002/diff/130001/remoting/protocol/test_...
remoting/protocol/test_event_matchers.h:15: namespace protocol {
I'd recommend putting these in a test namespace, either under remoting or
remoting::protocol, to avoid risk of clashes w/ production code names.

https://codereview.chromium.org/985863002/diff/130001/remoting/protocol/test_...
remoting/protocol/test_event_matchers.h:17: MATCHER_P2(EqualsUsbEvent,
usb_keycode, pressed, "") {
These should be EqualsKeyEvent, since we no longer support non-USB-style
keyboard input, besides the text events, below.

https://codereview.chromium.org/985863002/diff/130001/remoting/protocol/test_...
remoting/protocol/test_event_matchers.h:26: // events.
You mean in all tests, here and below?

[Rintaro Kuroiwa, 2015-03-12 18:51:27]

PTAL :)

https://codereview.chromium.org/985863002/diff/130001/remoting/client/plugin/...
File remoting/client/plugin/normalizing_input_filter_cros_unittest.cc (left):

https://codereview.chromium.org/985863002/diff/130001/remoting/client/plugin/...
remoting/client/plugin/normalizing_input_filter_cros_unittest.cc:32: static
const uint32 kTestLockStates = protocol::KeyEvent::LOCK_STATES_NUMLOCK;
On 2015/03/12 00:13:58, Wez wrote:
> Why remove this?

This was used only in the matcher below and MakeKeyEvent().
I moved the matcher to the header file so only MakeKeyEvent() will use this. And
because its used only once, I replaced it with the RHS.
We haven't lost the "NumLock" part of the matcher because I suffixed the matcher
with "WithNumLock"

I could put this back in if this might get used in the future.

https://codereview.chromium.org/985863002/diff/130001/remoting/client/plugin/...
File remoting/client/plugin/normalizing_input_filter_mac_unittest.cc (left):

https://codereview.chromium.org/985863002/diff/130001/remoting/client/plugin/...
remoting/client/plugin/normalizing_input_filter_mac_unittest.cc:29: static const
uint32 kTestLockStates = protocol::KeyEvent::LOCK_STATES_NUMLOCK;
On 2015/03/12 00:13:58, Wez wrote:
> And this?

Same as the other file.

https://codereview.chromium.org/985863002/diff/130001/remoting/protocol/test_...
File remoting/protocol/test_event_matchers.h (right):

https://codereview.chromium.org/985863002/diff/130001/remoting/protocol/test_...
remoting/protocol/test_event_matchers.h:15: namespace protocol {
On 2015/03/12 00:13:58, Wez wrote:
> I'd recommend putting these in a test namespace, either under remoting or
> remoting::protocol, to avoid risk of clashes w/ production code names.

Done.

https://codereview.chromium.org/985863002/diff/130001/remoting/protocol/test_...
remoting/protocol/test_event_matchers.h:17: MATCHER_P2(EqualsUsbEvent,
usb_keycode, pressed, "") {
On 2015/03/12 00:13:58, Wez wrote:
> These should be EqualsKeyEvent, since we no longer support non-USB-style
> keyboard input, besides the text events, below.

Done.

https://codereview.chromium.org/985863002/diff/130001/remoting/protocol/test_...
remoting/protocol/test_event_matchers.h:26: // events.
On 2015/03/12 00:13:58, Wez wrote:
> You mean in all tests, here and below?

Oops, this is me trying to be smart about keeping original comments but ended up
being cruft. Same for the matcher below.

[Wez, 2015-03-12 23:59:11]

lgtm

[Rintaro Kuroiwa, 2015-03-13 17:17:11]

The CQ bit was checked by rkuroiwa@chromium.org

[Rintaro Kuroiwa, 2015-03-13 17:17:11]

The patchset sent to the CQ was uploaded after l-g-t-m from wez@chromium.org
Link to the patchset: https://codereview.chromium.org/985863002/#ps200001
(title: "rebased")

[commit-bot: I haz the power, 2015-03-13 17:17:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/985863002/200001

[commit-bot: I haz the power, 2015-03-13 17:21:27]

Committed patchset #12 (id:200001)

[commit-bot: I haz the power, 2015-03-13 17:22:13]

Patchset 12 (id:??) landed as
https://crrev.com/2933366b4368740e7b433021d945741ea04e1798
Cr-Commit-Position: refs/heads/master@{#320517}