base/win/scoped_variant.h - Issue 985853005: base: Remove operator& from ScopedVariant and ScopedPropVariant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/win/scoped_variant.h

Issue 985853005: base: Remove operator& from ScopedVariant and ScopedPropVariant. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: scoped-operator: prop-ptr Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/win/scoped_variant.h

diff --git a/base/win/scoped_variant.h b/base/win/scoped_variant.h

index 6a28c6832b212464d25abbe0086f61ee848dc0ab..322fcf71e5574725ed6d887be4e5c49605bdc6b1 100644

--- a/base/win/scoped_variant.h

+++ b/base/win/scoped_variant.h

@@ -122,9 +122,7 @@ class BASE_EXPORT ScopedVariant {

// This support is necessary for the V_XYZ (e.g. V_BSTR) set of macros to

// work properly but still doesn't allow modifications since we want control

// over that.

- const VARIANT* operator&() const {

- return &var_;

- }

+ const VARIANT* ptr() const { return &var_; }

// Like other scoped classes (e.g scoped_refptr, ScopedComPtr, ScopedBstr)

// we support the assignment operator for the type we wrap.

« no previous file with comments | « base/win/scoped_propvariant.h ('k') | base/win/scoped_variant_unittest.cc » ('j') | no next file with comments »