Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 985853004: ash: Add missing xdisplaycheck dependency for tests (Closed)

Created:
5 years, 9 months ago by pkotwicz
Modified:
5 years, 9 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, oshima
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Add missing xdisplaycheck dependency for tests BUG=465344 TEST=linux_chromium_clobber_rel_ng does not block new ash_unittests from landing Committed: https://crrev.com/ceeb7432d9a58c80aed82feaf8066105a4815120 Cr-Commit-Position: refs/heads/master@{#319786}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M ash/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/ash.gyp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pkotwicz
Oshima, PTAL
5 years, 9 months ago (2015-03-07 02:19:44 UTC) #2
oshima
lgtm
5 years, 9 months ago (2015-03-09 22:53:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985853004/1
5 years, 9 months ago (2015-03-09 23:22:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 00:12:33 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 00:13:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ceeb7432d9a58c80aed82feaf8066105a4815120
Cr-Commit-Position: refs/heads/master@{#319786}

Powered by Google App Engine
This is Rietveld 408576698