Move NullWebViewClient implementation to chromium layer

Move NullWebViewClient implementation to chromium layer

Add AwContentsClient#hasWebViewClient so chromium layer knows when the
WebViewClient is null, and can fallback to default implementations.

Then move the default implementations to chrome layer.

Changes in implementation:

Use ContextWrapper instead of view.getContext(). This means the
"context instanceof Activity" check will never return true.
Use ContentViewCore.activityFromContext to check instead.

Call ContentViewClient.shouldOverrideKeyEvent directly instead of
keeping another copy of the implementation.

BUG=464491
Committed: https://crrev.com/1994b54ee3a21f9b9a36a6e83fa5c26cef9606bc
Cr-Commit-Position: refs/heads/master@{#319736}

[boliu, 2015-03-06 22:10:41]

boliu@chromium.org changed reviewers:
+ hush@chromium.org, sgurun@chromium.org

[boliu, 2015-03-06 22:10:41]

Even though I probably shouldn't land this, sending this out to see if you guys
have better ideas

https://codereview.chromium.org/985833004/diff/1/android_webview/glue/java/sr...
File
android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java
(left):

https://codereview.chromium.org/985833004/diff/1/android_webview/glue/java/sr...
android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java:199:
if (!(context instanceof Activity)) {
New implementation uses the ContextWrapper, so this is never going to be true. I
imagine always adding Intent.FLAG_ACTIVITY_NEW_TASK is not a good idea according
to b/18621737

Man, we have too many hacks. I don't think this CL can land because of this :(

[boliu, 2015-03-06 22:19:32]

We could expose ContextWrapper to chromium code, and call getBaseContext().

One step back from that, we could check for ContextWrapper at runtime. WDYT?

[boliu, 2015-03-06 22:35:14]

PS2 has the dirty hack..

[hush (inactive), 2015-03-06 23:43:55]

https://codereview.chromium.org/985833004/diff/20001/android_webview/java/src...
File
android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java
(right):

https://codereview.chromium.org/985833004/diff/20001/android_webview/java/src...
android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java:50:
private static boolean isActivityContext(Context context) {
ContextWrapper is already exposed to Chromium.
you could make use of this static class in content layer:
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/and...

[sgurun-gerrit only, 2015-03-07 00:11:35]

https://codereview.chromium.org/985833004/diff/1/android_webview/java/src/org...
File
android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java
(right):

https://codereview.chromium.org/985833004/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java:93:
// The check below is reflecting Clank's behavior and is a workaround for
s/Clank/Chrome for Android/. seems forgotten in glue layer code too.

[boliu, 2015-03-07 00:41:42]

New patch set up

https://codereview.chromium.org/985833004/diff/1/android_webview/java/src/org...
File
android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java
(right):

https://codereview.chromium.org/985833004/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java:93:
// The check below is reflecting Clank's behavior and is a workaround for
On 2015/03/07 00:11:35, sgurun wrote:
> s/Clank/Chrome for Android/. seems forgotten in glue layer code too.

Just chrome is fine I think :p

https://codereview.chromium.org/985833004/diff/20001/android_webview/java/src...
File
android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java
(right):

https://codereview.chromium.org/985833004/diff/20001/android_webview/java/src...
android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java:50:
private static boolean isActivityContext(Context context) {
On 2015/03/06 23:43:55, hush wrote:
> ContextWrapper is already exposed to Chromium.
> you could make use of this static class in content layer:
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/and...

Oh nice. I'm not the first person to run into this :p

[hush (inactive), 2015-03-07 01:19:35]

lgtm

[boliu, 2015-03-09 20:21:22]

cts WebViewClientTest still pass

[boliu, 2015-03-09 20:21:30]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2015-03-09 20:22:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/985833004/40001

[commit-bot: I haz the power, 2015-03-09 20:26:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-09 20:26:55]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[boliu, 2015-03-09 20:35:51]

cts still pass on rebased patch too :p

[boliu, 2015-03-09 20:36:04]

The CQ bit was checked by boliu@chromium.org

[boliu, 2015-03-09 20:36:05]

The patchset sent to the CQ was uploaded after l-g-t-m from hush@chromium.org
Link to the patchset: https://codereview.chromium.org/985833004/#ps60001 (title:
"rebase")

[commit-bot: I haz the power, 2015-03-09 20:36:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/985833004/60001

[commit-bot: I haz the power, 2015-03-09 21:26:17]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-09 21:26:42]

Patchset 4 (id:??) landed as
https://crrev.com/1994b54ee3a21f9b9a36a6e83fa5c26cef9606bc
Cr-Commit-Position: refs/heads/master@{#319736}