Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 98583008: Checkout Polymer using bower instead of the raw repository. (Closed)

Created:
7 years ago by raymes
Modified:
7 years ago
Reviewers:
bryeung, bshe
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, kevers, rsadam
Visibility:
Public.

Description

Checkout Polymer using bower instead of the raw repository. This adds Polymer to third_party using bower rather than the raw repository. Bower is the recommended way to manage Polymer. It makes it easy to update this dependency in chrome as well. Instructions for updating polymer are included in the README.chromium file. The existing references to polymer.min.js have been updated. This change is so that more polymer components can easily be added which are needed for the PDF extension. R=bshe@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241411

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : . #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+434 lines, -152 lines) Patch
A third_party/polymer/.bowerrc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/polymer/OWNERS View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
D third_party/polymer/PATENTS View 1 2 3 4 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/polymer/README.chromium View 1 2 3 4 1 chunk +20 lines, -8 lines 0 comments Download
D third_party/polymer/README.md View 1 2 3 4 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/polymer/build.log View 1 2 3 4 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/polymer/platform.js View 1 2 3 4 1 chunk +0 lines, -35 lines 0 comments Download
A third_party/polymer/platform/.bower.json View 1 2 3 4 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/polymer/platform/AUTHORS View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/polymer/platform/CONTRIBUTING.md View 1 2 3 4 1 chunk +73 lines, -0 lines 0 comments Download
A + third_party/polymer/platform/LICENSE View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/polymer/platform/PATENTS View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/polymer/platform/README.md View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/polymer/platform/bower.json View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/polymer/platform/build.log View 1 2 3 4 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/polymer/platform/platform.js View 1 2 3 4 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/polymer/platform/platform.js.map View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
D third_party/polymer/polymer.js View 1 2 3 4 1 chunk +0 lines, -30 lines 0 comments Download
A third_party/polymer/polymer/.bower.json View 1 2 3 4 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/polymer/polymer/AUTHORS View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/polymer/polymer/CONTRIBUTING.md View 1 2 3 4 1 chunk +73 lines, -0 lines 0 comments Download
A + third_party/polymer/polymer/LICENSE View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/polymer/polymer/PATENTS View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/polymer/polymer/README.md View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/polymer/polymer/bower.json View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download
A + third_party/polymer/polymer/build.log View 1 2 3 4 1 chunk +13 lines, -13 lines 0 comments Download
A third_party/polymer/polymer/polymer.html View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/polymer/polymer/polymer.js View 1 2 3 4 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/polymer/polymer/polymer.js.map View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/resources/polymer_loader.js View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
raymes
7 years ago (2013-12-16 06:26:25 UTC) #1
bryeung
I'm definitely not the right reviewer for this... Bryan On Mon, Dec 16, 2013 at ...
7 years ago (2013-12-16 10:49:49 UTC) #2
bshe
-bryeung +kevers, rsadam and myself thanks for doing this. Would you mind to update this ...
7 years ago (2013-12-16 18:25:26 UTC) #3
bshe
really + kevers and rsadam :p
7 years ago (2013-12-16 18:26:29 UTC) #4
raymes
bryeung: I removed you from the OWNERS file. On Tue, Dec 17, 2013 at 5:26 ...
7 years ago (2013-12-16 23:15:59 UTC) #5
raymes
Thanks! On Tue, Dec 17, 2013 at 5:25 AM, <bshe@chromium.org> wrote: > -bryeung > > ...
7 years ago (2013-12-16 23:17:34 UTC) #6
bryeung
Thanks! Bryan On Dec 16, 2013 6:15 PM, "Raymes Khoury" <raymes@chromium.org> wrote: > bryeung: I ...
7 years ago (2013-12-16 23:24:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/98583008/40001
7 years ago (2013-12-16 23:24:51 UTC) #8
commit-bot: I haz the power
List of reviewers changed. bryeung@chromium.org did a drive-by without LGTM'ing!
7 years ago (2013-12-17 06:49:23 UTC) #9
raymes
7 years ago (2013-12-17 23:38:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #5 manually as r241411 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698