Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: content/renderer/scheduler/renderer_task_queue_selector_unittest.cc

Issue 985813002: Experimental: Remove chromium shared timers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More tests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/scheduler/renderer_task_queue_selector_unittest.cc
diff --git a/content/renderer/scheduler/renderer_task_queue_selector_unittest.cc b/content/renderer/scheduler/renderer_task_queue_selector_unittest.cc
index 1112beb6b89a6a4f8c7093ec608145877e452e67..246f2ab0502774c5854213cd660e555a2cc80b5b 100644
--- a/content/renderer/scheduler/renderer_task_queue_selector_unittest.cc
+++ b/content/renderer/scheduler/renderer_task_queue_selector_unittest.cc
@@ -13,6 +13,18 @@
namespace content {
+class MockTaskQueueSelectorObserver
+ : public TaskQueueSelector::TaskQueueSelectorObserver {
+ public:
+ MockTaskQueueSelectorObserver() {}
+ virtual ~MockTaskQueueSelectorObserver() {}
+
+ MOCK_METHOD0(OnTaskQueueEnabled, void());
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(MockTaskQueueSelectorObserver);
+};
+
class RendererTaskQueueSelectorTest : public testing::Test {
public:
RendererTaskQueueSelectorTest()
@@ -104,7 +116,21 @@ TEST_F(RendererTaskQueueSelectorTest, TestControlPriority) {
EXPECT_THAT(PopTasks(), testing::ElementsAre(4, 2, 0, 1, 3));
}
+TEST_F(RendererTaskQueueSelectorTest, TestDisableReturnsTrueIfQueueWasEnabled) {
+ selector_.EnableQueue(1, RendererTaskQueueSelector::NORMAL_PRIORITY);
+ EXPECT_TRUE(selector_.DisableQueue(1));
+}
+
+TEST_F(RendererTaskQueueSelectorTest,
+ TestDisableReturnsFalseIfQueueWasAlreadyDisabled) {
+ selector_.DisableQueue(1);
+ EXPECT_FALSE(selector_.DisableQueue(1));
+}
+
TEST_F(RendererTaskQueueSelectorTest, TestDisableEnable) {
+ MockTaskQueueSelectorObserver mock_observer;
+ selector_.RegisterTaskQueueObserver(&mock_observer);
+
std::vector<base::PendingTask> tasks = GetTasks(5);
size_t queue_order[] = {0, 1, 2, 3, 4};
PushTasks(tasks, queue_order);
@@ -113,6 +139,8 @@ TEST_F(RendererTaskQueueSelectorTest, TestDisableEnable) {
selector_.DisableQueue(4);
EXPECT_FALSE(selector_.IsQueueEnabled(4));
EXPECT_THAT(PopTasks(), testing::ElementsAre(0, 1, 3));
+
+ EXPECT_CALL(mock_observer, OnTaskQueueEnabled()).Times(2);
selector_.EnableQueue(2, RendererTaskQueueSelector::BEST_EFFORT_PRIORITY);
EXPECT_THAT(PopTasks(), testing::ElementsAre(2));
selector_.EnableQueue(4, RendererTaskQueueSelector::NORMAL_PRIORITY);
« no previous file with comments | « content/renderer/scheduler/renderer_task_queue_selector.cc ('k') | content/renderer/scheduler/task_queue_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698