Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1683)

Unified Diff: content/renderer/scheduler/renderer_scheduler_impl.h

Issue 985813002: Experimental: Remove chromium shared timers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More tests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/scheduler/renderer_scheduler_impl.h
diff --git a/content/renderer/scheduler/renderer_scheduler_impl.h b/content/renderer/scheduler/renderer_scheduler_impl.h
index c908a974a0d8f21cf24f8cb34d36fc053a1d68c8..508e3a0b90d870b9f55d0e41f5f54b190f4f2a0f 100644
--- a/content/renderer/scheduler/renderer_scheduler_impl.h
+++ b/content/renderer/scheduler/renderer_scheduler_impl.h
@@ -35,6 +35,7 @@ class CONTENT_EXPORT RendererSchedulerImpl : public RendererScheduler {
scoped_refptr<base::SingleThreadTaskRunner> CompositorTaskRunner() override;
scoped_refptr<SingleThreadIdleTaskRunner> IdleTaskRunner() override;
scoped_refptr<base::SingleThreadTaskRunner> LoadingTaskRunner() override;
+ scoped_refptr<base::SingleThreadTaskRunner> TimerTaskRunner() override;
void WillBeginFrame(const cc::BeginFrameArgs& args) override;
void BeginFrameNotExpectedSoon() override;
void DidCommitFrameToCompositor() override;
@@ -47,6 +48,8 @@ class CONTENT_EXPORT RendererSchedulerImpl : public RendererScheduler {
void RemoveTaskObserver(
base::MessageLoop::TaskObserver* task_observer) override;
void Shutdown() override;
+ void SuspendTimerQueue() override;
+ void ResumeTimerQueue() override;
void SetTimeSourceForTesting(scoped_refptr<cc::TestNowSource> time_source);
void SetWorkBatchSizeForTesting(size_t work_batch_size);
@@ -59,6 +62,7 @@ class CONTENT_EXPORT RendererSchedulerImpl : public RendererScheduler {
DEFAULT_TASK_QUEUE,
COMPOSITOR_TASK_QUEUE,
LOADING_TASK_QUEUE,
+ TIMER_TASK_QUEUE,
IDLE_TASK_QUEUE,
CONTROL_TASK_QUEUE,
CONTROL_TASK_AFTER_WAKEUP_QUEUE,
@@ -145,6 +149,9 @@ class CONTENT_EXPORT RendererSchedulerImpl : public RendererScheduler {
void StartIdlePeriod();
void EndIdlePeriod();
+ // Enables the timer queue if timer_queue_suspended_ is zero.
+ void MaybeEnableTimerQueue();
+
base::TimeTicks Now() const;
base::ThreadChecker main_thread_checker_;
@@ -155,6 +162,7 @@ class CONTENT_EXPORT RendererSchedulerImpl : public RendererScheduler {
scoped_refptr<base::SingleThreadTaskRunner> default_task_runner_;
scoped_refptr<base::SingleThreadTaskRunner> compositor_task_runner_;
scoped_refptr<base::SingleThreadTaskRunner> loading_task_runner_;
+ scoped_refptr<base::SingleThreadTaskRunner> timer_task_runner_;
scoped_refptr<SingleThreadIdleTaskRunner> idle_task_runner_;
base::Closure update_policy_closure_;
@@ -173,6 +181,7 @@ class CONTENT_EXPORT RendererSchedulerImpl : public RendererScheduler {
blink::WebInputEvent::Type last_input_type_;
InputStreamState input_stream_state_;
PollableNeedsUpdateFlag policy_may_need_update_;
+ int timer_queue_suspended_; // counter
scoped_refptr<cc::TestNowSource> time_source_;
« no previous file with comments | « content/renderer/scheduler/renderer_scheduler.h ('k') | content/renderer/scheduler/renderer_scheduler_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698