Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 985803002: Remove code object from StackHandler. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove code object from StackHandler. This reduces the size of the StackHandler by one word. We no longer need to keep track of the code object, as the stack walk finds it. R=yangguo@chromium.org Committed: https://crrev.com/e0aa8ebf933b4c659e1c4a01ba244c5de452ff1c Cr-Commit-Position: refs/heads/master@{#27103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -66 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 chunk +8 lines, -10 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M src/frames.h View 3 chunks +3 lines, -6 lines 0 comments Download
M src/frames.cc View 3 chunks +8 lines, -11 lines 0 comments Download
M src/frames-inl.h View 3 chunks +0 lines, -13 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M src/isolate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Michael Starzinger
5 years, 9 months ago (2015-03-06 16:52:40 UTC) #1
Michael Starzinger
I applied the first layer of StackHandler'b'gone and let it soak for a while. I ...
5 years, 9 months ago (2015-03-06 16:53:54 UTC) #2
Yang
lgtm
5 years, 9 months ago (2015-03-10 12:49:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985803002/1
5 years, 9 months ago (2015-03-10 12:52:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 13:20:16 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 13:20:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0aa8ebf933b4c659e1c4a01ba244c5de452ff1c
Cr-Commit-Position: refs/heads/master@{#27103}

Powered by Google App Engine
This is Rietveld 408576698