Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 9858007: Fix a couple of regressions that made it in before the weekend. (Closed)

Created:
6 years, 1 month ago by tommi (sloooow) - chröme
Modified:
6 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Fix a couple of regressions that made it in before the weekend. 1) Since the 'closed' closure now runs on the calling thread and not the audio thread assertions in the callback failed. 2) output_buffer_size() was returning the input buffer size. now fixed. Also updating the output side to follow the same rule for the 'onclosed' callback. BUG=120110, 120111 TEST=Run content_unittests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128895

Patch Set 1 #

Patch Set 2 : Fix media tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -43 lines) Patch
M content/browser/renderer_host/media/audio_input_renderer_host.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.cc View 1 chunk +1 line, -11 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 1 chunk +1 line, -9 lines 0 comments Download
M content/renderer/media/webrtc_audio_device_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_input_controller.h View 1 chunk +3 lines, -3 lines 0 comments Download
M media/audio/audio_output_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_controller.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M media/audio/audio_output_controller_unittest.cc View 1 5 chunks +20 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tommi (sloooow) - chröme
6 years, 1 month ago (2012-03-26 09:16:54 UTC) #1
henrika (OOO until Aug 14)
LGTM.
6 years, 1 month ago (2012-03-26 09:19:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/9858007/4001
6 years, 1 month ago (2012-03-26 09:33:48 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2012-03-26 11:55:46 UTC) #4
Change committed as 128895

Powered by Google App Engine
This is Rietveld 408576698