Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: components/metrics/profiler/tracking_synchronizer_unittest.cc

Issue 985773002: Introducing phased profiling framework (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@write_to_file
Patch Set: Additional isherman@ comments. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/profiler/tracking_synchronizer_unittest.cc
diff --git a/components/metrics/profiler/tracking_synchronizer_unittest.cc b/components/metrics/profiler/tracking_synchronizer_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d566d8648cebd914a7f22407e12abdab9960c0a7
--- /dev/null
+++ b/components/metrics/profiler/tracking_synchronizer_unittest.cc
@@ -0,0 +1,118 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/memory/ref_counted.h"
+#include "base/tracked_objects.h"
+#include "components/metrics/profiler/tracking_synchronizer.h"
+#include "components/metrics/profiler/tracking_synchronizer_observer.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using tracked_objects::ProcessDataPhaseSnapshot;
+using tracked_objects::TaskSnapshot;
+
+namespace metrics {
+
+namespace {
+
+class TestObserver : public TrackingSynchronizerObserver {
+ public:
+ TestObserver() {}
+
+ ~TestObserver() {
+ EXPECT_TRUE(got_phase_0_);
+ EXPECT_TRUE(got_phase_1_);
+ }
+
+ virtual void ReceivedProfilerData(
+ const tracked_objects::ProcessDataPhaseSnapshot& process_data_phase,
+ base::ProcessId process_id,
+ content::ProcessType process_type,
+ int profiling_phase,
+ const base::TimeDelta& phase_start,
+ const base::TimeDelta& phase_finish,
+ const ProfilerEvents& past_events) override {
+ EXPECT_EQ(239ul, process_id);
+ EXPECT_EQ(content::ProcessType::PROCESS_TYPE_PLUGIN, process_type);
+ ASSERT_EQ(1u, process_data_phase.tasks.size());
+
+ switch (profiling_phase) {
+ case 0:
+ EXPECT_FALSE(got_phase_0_);
+ got_phase_0_ = true;
+
+ EXPECT_EQ(base::TimeDelta::FromMilliseconds(0), phase_start);
+ EXPECT_EQ(base::TimeDelta::FromMilliseconds(222), phase_finish);
+
+ EXPECT_EQ("death_thread0",
+ process_data_phase.tasks[0].death_thread_name);
+ EXPECT_EQ(0u, past_events.size());
+ break;
+
+ case 1:
+ EXPECT_FALSE(got_phase_1_);
+ got_phase_1_ = true;
+
+ EXPECT_EQ(base::TimeDelta::FromMilliseconds(222), phase_start);
+ EXPECT_EQ(base::TimeDelta::FromMilliseconds(666), phase_finish);
+
+ EXPECT_EQ("death_thread1",
+ process_data_phase.tasks[0].death_thread_name);
+ ASSERT_EQ(1u, past_events.size());
+ EXPECT_EQ(ProfilerEventProto::EVENT_FIRST_NONEMPTY_PAINT,
+ past_events[0]);
+ break;
+
+ default:
+ EXPECT_FALSE("profiling_phase is neither 0 nor 1");
+ }
+ }
+
+ private:
+ bool got_phase_0_ = false;
+ bool got_phase_1_ = false;
+
+ DISALLOW_COPY_AND_ASSIGN(TestObserver);
+};
+
+base::TimeTicks TestTimeFromMs(int64 ms) {
+ return base::TimeTicks() + base::TimeDelta::FromMilliseconds(ms);
+}
+
+} // namespace
+
+TEST(TrackingSynchronizerTest, ProfilerData) {
+ // Testing how TrackingSynchronizer reports 2 phases of profiling
+ // test_observer
+ // TrackingSynchronizerObserver.
Ilya Sherman 2015/03/19 01:00:51 nit: re-wrap?
vadimt 2015/03/19 18:01:47 Done.
+ content::TestBrowserThreadBundle thread_bundle;
+
+ scoped_refptr<TrackingSynchronizer> tracking_synchronizer =
+ new TrackingSynchronizer(TestTimeFromMs(111));
+
+ // Mimic a phase change event.
+ tracking_synchronizer->phase_completion_events_sequence_.push_back(
+ ProfilerEventProto::EVENT_FIRST_NONEMPTY_PAINT);
+ tracking_synchronizer->phase_start_times_.push_back(TestTimeFromMs(333));
+
+ tracked_objects::ProcessDataSnapshot profiler_data;
+ ProcessDataPhaseSnapshot snapshot0;
+ tracked_objects::TaskSnapshot task_snapshot0;
+ task_snapshot0.death_thread_name = "death_thread0";
+ snapshot0.tasks.push_back(task_snapshot0);
+ ProcessDataPhaseSnapshot snapshot1;
+ profiler_data.phased_process_data_snapshots[0] = snapshot0;
+ tracked_objects::TaskSnapshot task_snapshot1;
+ task_snapshot1.death_thread_name = "death_thread1";
+ snapshot1.tasks.push_back(task_snapshot1);
+ profiler_data.phased_process_data_snapshots[1] = snapshot1;
+ profiler_data.process_id = 239;
+
+ TestObserver test_observer;
+ tracking_synchronizer->SendData(profiler_data,
+ content::ProcessType::PROCESS_TYPE_PLUGIN,
+ TestTimeFromMs(777), &test_observer);
+}
+
+} // namespace metrics

Powered by Google App Engine
This is Rietveld 408576698