Introducing phased profiling framework

content/child/child_thread_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/child_thread_impl.h"
 
 #include <signal.h>
 
 #include <string>
 
@@ skipping 621 matching lines @@
   else
     IPC::Logging::GetInstance()->Disable();
 }
 #endif  //  IPC_MESSAGE_LOG_ENABLED
 
 void ChildThreadImpl::OnSetProfilerStatus(ThreadData::Status status) {
   ThreadData::InitializeAndSetTrackingStatus(status);
 }
 
 void ChildThreadImpl::OnGetChildProfilerData(int sequence_number) {
-  tracked_objects::ProcessDataSnapshot process_data;
-  ThreadData::Snapshot(&process_data);
+  tracked_objects::ProcessDataSnapshot process_data_snapshot;
+  ThreadData::GetProcessDataSnapshot(&process_data_snapshot);
 
   Send(new ChildProcessHostMsg_ChildProfilerData(sequence_number,
-                                                 process_data));
+                                                 process_data_snapshot));

[Ilya Sherman, 2015/03/10 00:48:11]

Optional nit: IMO none of the renames here help with readability.  I don't feel
strongly about this, but I do think that shorter names, as long as they remain
clear, are generally better.

[vadimt, 2015/03/13 23:18:02]

Agreed. Must be a result of massive renames throughout the code.

 }
 
 void ChildThreadImpl::OnDumpHandles() {
 #if defined(OS_WIN)
   scoped_refptr<HandleEnumerator> handle_enum(
       new HandleEnumerator(
           base::CommandLine::ForCurrentProcess()->HasSwitch(
               switches::kAuditAllHandles)));
   handle_enum->EnumerateHandles();
   Send(new ChildProcessHostMsg_DumpHandlesDone);
@@ skipping 78 matching lines @@
   // doesn't cause such issues. TODO(gab): Remove this once the experiment is
   // over (http://crbug.com/458594).
   base::FieldTrial* trial =
       base::FieldTrialList::Find("BackgroundRendererProcesses");
   if (trial && trial->group_name() == "AllowBackgroundModeFromRenderer")
     base::Process::Current().SetProcessBackgrounded(background);
 #endif  // OS_WIN
 }
 
 }  // namespace content